From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: [PATCH v2 1/4] drm: Mark up accesses of vblank->enabled outside of its spinlock Date: Fri, 17 Mar 2017 20:20:27 +0000 Message-ID: <20170317202030.24410-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3JkZXIgdGhlIHVwZGF0ZSB0byB2YmxhbmstPmVuYWJsZWQgYWZ0ZXIgdGhlIHRpbWVzdGFtcCBp cyBwcmltZWQgc28KdGhhdCBhIGNvbmN1cnJlbnQgdW5sb2NrZWQgcmVhZGVyIHdpbGwgb25seSBz ZWUgdGhlIHZibGFuay0+ZW5hYmxlZCB3aXRoCnRoZSBjdXJyZW50IHRpbWVzdGFtcC4KCnYyOiB2 YmxhbmstPmVuYWJsZSBpcyBndWFyZGVkIGJ5IGRldi0+dmJsX2xvY2sgbm90CmRldi0+dmJsYW5r X3RpbWVfbG9jaywgdXBkYXRlIHRoZSBSRUFEX09OQ0UgYWNjb3JkaW5nbHkuCgpEbyBub3QgYWRk IGEgUkVBRF9PTkNFKHZibGFuay0+ZW5hYmxlZCkgaW5zaWRlIHRoZSBpbnRlcnJ1cHQgaGFuZGxl ciB0bwphdm9pZCBtaXNzaW5nIGFuIGludGVycnVwdCB3aGlsc3QgcmFjaW5nIHdpdGggZW5hYmxl X3ZibGFuaygpCgpTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+CkNjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgotLS0KIGRyaXZl cnMvZ3B1L2RybS9kcm1faXJxLmMgfCAyMyArKysrKysrKysrKysrKy0tLS0tLS0tLQogMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKaW5k ZXggNTNhNTI2YzdiMjRkLi5jNDdlMDdjODkxMzYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1faXJxLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwpAQCAtMzI1LDYgKzMy NSw4IEBAIHN0YXRpYyB2b2lkIHZibGFua19kaXNhYmxlX2FuZF9zYXZlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQogCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZi bGFuayA9ICZkZXYtPnZibGFua1twaXBlXTsKIAl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwogCisJ YXNzZXJ0X3NwaW5fbG9ja2VkKCZkZXYtPnZibF9sb2NrKTsKKwogCS8qIFByZXZlbnQgdmJsYW5r IGlycSBwcm9jZXNzaW5nIHdoaWxlIGRpc2FibGluZyB2YmxhbmsgaXJxcywKIAkgKiBzbyBubyB1 cGRhdGVzIG9mIHRpbWVzdGFtcHMgb3IgY291bnQgY2FuIGhhcHBlbiBhZnRlciB3ZSd2ZQogCSAq IGRpc2FibGVkLiBOZWVkZWQgdG8gcHJldmVudCByYWNlcyBpbiBjYXNlIG9mIGRlbGF5ZWQgaXJx J3MuCkBAIC0zMzYsMTAgKzMzOCw4IEBAIHN0YXRpYyB2b2lkIHZibGFua19kaXNhYmxlX2FuZF9z YXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQogCSAqIGNhbGxp bmcgdGhlIC0+ZGlzYWJsZV92YmxhbmsoKSBvcGVyYXRpb24gaW4gYXRvbWljIGNvbnRleHQgd2l0 aCB0aGUKIAkgKiBoYXJkd2FyZSBwb3RlbnRpYWxseSBydW50aW1lIHN1c3BlbmRlZC4KIAkgKi8K LQlpZiAodmJsYW5rLT5lbmFibGVkKSB7CisJaWYgKGNtcHhjaGdfcmVsYXhlZCgmdmJsYW5rLT5l bmFibGVkLCB0cnVlLCBmYWxzZSkpCiAJCV9fZGlzYWJsZV92YmxhbmsoZGV2LCBwaXBlKTsKLQkJ dmJsYW5rLT5lbmFibGVkID0gZmFsc2U7Ci0JfQogCiAJLyoKIAkgKiBBbHdheXMgdXBkYXRlIHRo ZSBjb3VudCBhbmQgdGltZXN0YW1wIHRvIG1haW50YWluIHRoZQpAQCAtMzg0LDcgKzM4NCw3IEBA IHZvaWQgZHJtX3ZibGFua19jbGVhbnVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCiAJZm9yIChw aXBlID0gMDsgcGlwZSA8IGRldi0+bnVtX2NydGNzOyBwaXBlKyspIHsKIAkJc3RydWN0IGRybV92 YmxhbmtfY3J0YyAqdmJsYW5rID0gJmRldi0+dmJsYW5rW3BpcGVdOwogCi0JCVdBUk5fT04odmJs YW5rLT5lbmFibGVkICYmCisJCVdBUk5fT04oUkVBRF9PTkNFKHZibGFuay0+ZW5hYmxlZCkgJiYK IAkJCWRybV9jb3JlX2NoZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpOwogCiAJCWRl bF90aW1lcl9zeW5jKCZ2YmxhbmstPmRpc2FibGVfdGltZXIpOwpAQCAtMTEwNSwxMSArMTEwNSwx NiBAQCBzdGF0aWMgaW50IGRybV92YmxhbmtfZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHVuc2lnbmVkIGludCBwaXBlKQogCQkgKi8KIAkJcmV0ID0gX19lbmFibGVfdmJsYW5rKGRldiwg cGlwZSk7CiAJCURSTV9ERUJVRygiZW5hYmxpbmcgdmJsYW5rIG9uIGNydGMgJXUsIHJldDogJWRc biIsIHBpcGUsIHJldCk7Ci0JCWlmIChyZXQpCisJCWlmIChyZXQpIHsKIAkJCWF0b21pY19kZWMo JnZibGFuay0+cmVmY291bnQpOwotCQllbHNlIHsKLQkJCXZibGFuay0+ZW5hYmxlZCA9IHRydWU7 CisJCX0gZWxzZSB7CiAJCQlkcm1fdXBkYXRlX3ZibGFua19jb3VudChkZXYsIHBpcGUsIDApOwor CQkJLyogZHJtX3VwZGF0ZV92YmxhbmtfY291bnQoKSBpbmNsdWRlcyBhIHdtYiBzbyB3ZSBqdXN0 CisJCQkgKiBuZWVkIHRvIGVuc3VyZSB0aGF0IHRoZSBjb21waWxlciBlbWl0cyB0aGUgd3JpdGUK KwkJCSAqIHRvIG1hcmsgdGhlIHZibGFuayBhcyBlbmFibGVkIGFmdGVyIHRoZSBjYWxsCisJCQkg KiB0byBkcm1fdXBkYXRlX3ZibGFua19jb3VudCgpLgorCQkJICovCisJCQlXUklURV9PTkNFKHZi bGFuay0+ZW5hYmxlZCwgdHJ1ZSk7CiAJCX0KIAl9CiAKQEAgLTE1MTcsNyArMTUyMiw3IEBAIHN0 YXRpYyBpbnQgZHJtX3F1ZXVlX3ZibGFua19ldmVudChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1 bnNpZ25lZCBpbnQgcGlwZSwKIAkgKiB2YmxhbmsgZGlzYWJsZSwgc28gbm8gbmVlZCBmb3IgZnVy dGhlciBsb2NraW5nLiAgVGhlIHJlZmVyZW5jZSBmcm9tCiAJICogZHJtX3ZibGFua19nZXQoKSBw cm90ZWN0cyBhZ2FpbnN0IHZibGFuayBkaXNhYmxlIGZyb20gYW5vdGhlciBzb3VyY2UuCiAJICov Ci0JaWYgKCF2YmxhbmstPmVuYWJsZWQpIHsKKwlpZiAoIVJFQURfT05DRSh2YmxhbmstPmVuYWJs ZWQpKSB7CiAJCXJldCA9IC1FSU5WQUw7CiAJCWdvdG8gZXJyX3VubG9jazsKIAl9CkBAIC0xNjQ0 LDcgKzE2NDksNyBAQCBpbnQgZHJtX3dhaXRfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsCiAJCURSTV9XQUlUX09OKHJldCwgdmJsYW5rLT5xdWV1ZSwgMyAqIEhaLAog CQkJICAgICgoKGRybV92YmxhbmtfY291bnQoZGV2LCBwaXBlKSAtCiAJCQkgICAgICAgdmJsd2Fp dC0+cmVxdWVzdC5zZXF1ZW5jZSkgPD0gKDEgPDwgMjMpKSB8fAotCQkJICAgICAhdmJsYW5rLT5l bmFibGVkIHx8CisJCQkgICAgICFSRUFEX09OQ0UodmJsYW5rLT5lbmFibGVkKSB8fAogCQkJICAg ICAhZGV2LT5pcnFfZW5hYmxlZCkpOwogCX0KIAotLSAKMi4xMS4wCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK