From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751096AbdCQUqh (ORCPT ); Fri, 17 Mar 2017 16:46:37 -0400 Received: from mga11.intel.com ([192.55.52.93]:15487 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbdCQUqd (ORCPT ); Fri, 17 Mar 2017 16:46:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,178,1486454400"; d="scan'208";a="1143898797" Date: Fri, 17 Mar 2017 22:44:29 +0200 From: Jarkko Sakkinen To: Alexander.Steffen@infineon.com Cc: tpmdd-devel@lists.sourceforge.net, dhowells@redhat.com, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, linux-security-module@vger.kernel.org, peterhuewe@gmx.de Subject: Re: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces Message-ID: <20170317204429.wsoe4r4jne437kyc@intel.com> References: <20170303151912.14752-1-jarkko.sakkinen@linux.intel.com> <20170303151912.14752-5-jarkko.sakkinen@linux.intel.com> <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen@infineon.com wrote: > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm- > > interface.c > > index 20b1fe3..db5ffe9 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct > > tpm_chip *chip, const u8 *cmd, > > * 0 when the operation is successful. > > * A negative number for system errors (errno). > > */ > > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz, > > - unsigned int flags) > > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space, > > + u8 *buf, size_t bufsiz, unsigned int flags) > > When adding parameters, please also update the parameter documentation > at the top of the function. It is missing for the new parameter > "space" here. I missed that. I'll update the commits with the proper documentation. > Alexander /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen) Date: Fri, 17 Mar 2017 22:44:29 +0200 Subject: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces In-Reply-To: <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com> References: <20170303151912.14752-1-jarkko.sakkinen@linux.intel.com> <20170303151912.14752-5-jarkko.sakkinen@linux.intel.com> <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com> Message-ID: <20170317204429.wsoe4r4jne437kyc@intel.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen at infineon.com wrote: > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm- > > interface.c > > index 20b1fe3..db5ffe9 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct > > tpm_chip *chip, const u8 *cmd, > > * 0 when the operation is successful. > > * A negative number for system errors (errno). > > */ > > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz, > > - unsigned int flags) > > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space, > > + u8 *buf, size_t bufsiz, unsigned int flags) > > When adding parameters, please also update the parameter documentation > at the top of the function. It is missing for the new parameter > "space" here. I missed that. I'll update the commits with the proper documentation. > Alexander /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v3 4/7] tpm: infrastructure for TPM spaces Date: Fri, 17 Mar 2017 22:44:29 +0200 Message-ID: <20170317204429.wsoe4r4jne437kyc@intel.com> References: <20170303151912.14752-1-jarkko.sakkinen@linux.intel.com> <20170303151912.14752-5-jarkko.sakkinen@linux.intel.com> <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1aa1c9d32fd446f69551a36c37f0ed16-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org Cc: James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org wrote: > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm- > > interface.c > > index 20b1fe3..db5ffe9 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct > > tpm_chip *chip, const u8 *cmd, > > * 0 when the operation is successful. > > * A negative number for system errors (errno). > > */ > > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz, > > - unsigned int flags) > > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space, > > + u8 *buf, size_t bufsiz, unsigned int flags) > > When adding parameters, please also update the parameter documentation > at the top of the function. It is missing for the new parameter > "space" here. I missed that. I'll update the commits with the proper documentation. > Alexander /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot