From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbdCRRu0 (ORCPT ); Sat, 18 Mar 2017 13:50:26 -0400 Received: from mail.skyhub.de ([5.9.137.197]:46994 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbdCRRuS (ORCPT ); Sat, 18 Mar 2017 13:50:18 -0400 Date: Sat, 18 Mar 2017 18:39:43 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: linux-edac , lkml Subject: [PATCH 2/2] EDAC, pnd2_edac: Fix !EDAC_DEBUG build Message-ID: <20170318173943.GE4231@nazgul.tnic> References: <20170308174539.14432-1-qiuxu.zhuo@intel.com> <20170316114226.i2chiuvmbpwhrwyv@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F612285E4@ORSMSX114.amr.corp.intel.com> <20170318173703.GC4231@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170318173703.GC4231@nazgul.tnic> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Provide debugfs function stubs when EDAC_DEBUG is not enabled so that we don't fail the build: drivers/edac/pnd2_edac.c: In function ‘pnd2_init’: drivers/edac/pnd2_edac.c:1521:2: error: implicit declaration of function ‘setup_pnd2_debug’ [-Werror=implicit-function-declaration] setup_pnd2_debug(); ^ drivers/edac/pnd2_edac.c: In function ‘pnd2_exit’: drivers/edac/pnd2_edac.c:1529:2: error: implicit declaration of function ‘teardown_pnd2_debug’ [-Werror=implicit-function-declaration] teardown_pnd2_debug(); ^ Signed-off-by: Borislav Petkov --- drivers/edac/pnd2_edac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index 14d39f05226e..ec2e349d728d 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -1435,7 +1435,11 @@ static void teardown_pnd2_debug(void) { debugfs_remove_recursive(pnd2_test); } -#endif +#else +static void setup_pnd2_debug(void) {} +static void teardown_pnd2_debug(void) {} +#endif /* CONFIG_EDAC_DEBUG */ + static int pnd2_probe(void) { -- 2.8.4 -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --