From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978AbdCRSxV (ORCPT ); Sat, 18 Mar 2017 14:53:21 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:39120 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbdCRSxK (ORCPT ); Sat, 18 Mar 2017 14:53:10 -0400 X-Auth-Info: Yix8DIDqpI5Ws+dkPMXOxCuYlmYZj7v6tmKXTWOTnA8= Date: Sat, 18 Mar 2017 19:27:50 +0100 From: Anatolij Gustschin To: matthew.gerlach@linux.intel.com Cc: atull@kernel.org, moritz.fischer@ettus.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v5 4/4] fpga pr ip: Platform driver for Altera Partial Reconfiguration IP. Message-ID: <20170318192750.716e9b28@crub> In-Reply-To: <1489174827-6033-5-git-send-email-matthew.gerlach@linux.intel.com> References: <1489174827-6033-1-git-send-email-matthew.gerlach@linux.intel.com> <1489174827-6033-5-git-send-email-matthew.gerlach@linux.intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, On Fri, 10 Mar 2017 11:40:27 -0800 matthew.gerlach@linux.intel.com matthew.gerlach@linux.intel.com wrote: ... >+#include "altera-pr-ip-core.h" Shouldn't we put this header to include/linux? Compiling the out-of-tree modules using alt_pr_register/alt_pr_unregister will not work if this header is in drivers/fpga. ... >+ >+module_platform_driver(alt_pr_platform_driver); Please add MODULE_LICENSE("GPL v2") here. Otherwise, when built as a module it cannot be loaded because the alt_pr register/unregister functions are exported as GPL only. Also please add module author and description. Thanks, Anatolij