From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: laurent.pinchart@ideasonboard.com, geert+renesas@glider.be,
linus.walleij@linaro.org, linux-renesas-soc@vger.kernel.org
Subject: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name
Date: Sat, 18 Mar 2017 21:52:26 +0100 [thread overview]
Message-ID: <20170318205226.GA11403@x230> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 0001-pinctrl-sh-pfc-Print-correct-pinmux-info-name.patch --]
[-- Type: text/x-diff, Size: 1410 bytes --]
>From cce7953dac965d620bb4fe5a456cffe40793f39b Mon Sep 17 00:00:00 2001
From: Eugeniu Rosca <erosca@de.adit-jv.com>
Date: Tue, 28 Feb 2017 13:38:36 +0100
Subject: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name
commit 0c151062f32c ("sh-pfc: Add support for SoC-specific
initialization") allows defining SoC specific init functions.
Such custom functions can register new pinmux info structures.
Here is an example:
static int my_pinmux_init(struct sh_pfc *pfc)
{
if (my_criteria())
pfc->info = &new_pinmux_info;
}
A side effect of the pfc->info update in the above example is that
the `const struct sh_pfc_soc_info *info` pointer used in the probe
routine becomes outdated. One consequence of it is printing the wrong
pinmux info structure name at the end of `sh_pfc_probe()`. Fix this.
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
drivers/pinctrl/sh-pfc/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
index 6399eb1feb12..37fc70fb8e4d 100644
--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -703,7 +703,7 @@ static int sh_pfc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pfc);
- dev_info(pfc->dev, "%s support registered\n", info->name);
+ dev_info(pfc->dev, "%s support registered\n", pfc->info->name);
return 0;
}
--
2.12.0
next reply other threads:[~2017-03-18 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 20:52 Eugeniu Rosca [this message]
2017-03-19 14:02 ` [PATCH] pinctrl: sh-pfc: Print correct pinmux info name Geert Uytterhoeven
2017-03-19 16:20 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318205226.GA11403@x230 \
--to=roscaeugeniu@gmail.com \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.