From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v9 4/4] platform/x86/dell-*: Call led_classdev_notify_brightness_hw_changed on kbd brightness change
Date: Sun, 19 Mar 2017 19:11:43 +0100 [thread overview]
Message-ID: <201703191911.43694@pali> (raw)
In-Reply-To: <16957a6a-be85-8771-2000-978c4bc88270@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 1029 bytes --]
On Sunday 19 March 2017 19:06:19 Hans de Goede wrote:
> Hi,
>
> On 19-03-17 16:10, Pali Rohár wrote:
> > On Thursday 16 March 2017 11:55:35 Hans de Goede wrote:
> >> Changes in v9:
> >> -Only listen to type 0x0010 kbd-led events in dell-wmi.c, these
> >> only trigger on hotkey presses
> >> -Drop the new / previous brightness comparison from dell-laptop.c
> >> now that we only get events on hotkey presses it is no longer
> >> necessary ---
> >
> > Hi! I'm really not sure if this change is correct there.
> >
> > Now you are only listening for keypress "change kbd backlight", but
> > some dell machines could change keyboard backlight also in other
> > different situations, like attaching AC adapter. I guess (but I'm
> > not sure) this probably does not send keypress event.
>
> I'm not aware of any Dells doing such a thing, if we encounter any
> then we can deal with that if and when that happens.
Ok, go ahead. We can fix issues when appear later.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2017-03-19 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 10:55 [PATCH v9 1/4] platform/x86/dell-*: Add a generic dell-laptop notifier chain Hans de Goede
2017-03-16 10:55 ` [PATCH v9 2/4] platform/x86/dell-laptop: Refactor kbd_led_triggers_store() Hans de Goede
2017-03-16 10:55 ` [PATCH v9 3/4] platform/x86/dell-laptop: Protect kbd_state against races Hans de Goede
2017-03-16 10:55 ` [PATCH v9 4/4] platform/x86/dell-*: Call led_classdev_notify_brightness_hw_changed on kbd brightness change Hans de Goede
2017-03-17 22:33 ` Darren Hart
2017-03-18 13:42 ` Hans de Goede
2017-03-19 15:10 ` Pali Rohár
2017-03-19 18:06 ` Hans de Goede
2017-03-19 18:11 ` Pali Rohár [this message]
2017-03-22 16:59 ` Darren Hart
2017-03-23 8:58 ` Pali Rohár
2017-03-22 16:53 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201703191911.43694@pali \
--to=pali.rohar@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.