From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752417AbdCSUIg (ORCPT ); Sun, 19 Mar 2017 16:08:36 -0400 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:45322 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752131AbdCSUIf (ORCPT ); Sun, 19 Mar 2017 16:08:35 -0400 Date: Sun, 19 Mar 2017 20:08:21 +0000 From: Mel Gorman To: J?r?me Glisse Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Naoya Horiguchi , David Nellans , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3 Message-ID: <20170319200821.GB2774@techsingularity.net> References: <1489680335-6594-1-git-send-email-jglisse@redhat.com> <1489680335-6594-2-git-send-email-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489680335-6594-2-git-send-email-jglisse@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 12:05:20PM -0400, J?r?me Glisse wrote: > When hotpluging memory we want more informations on the type of memory and > its properties. Replace the device boolean flag by an int and define a set > of flags. > > New property for device memory is an opt-in flag to allow page migration > from and to a ZONE_DEVICE. Existing user of ZONE_DEVICE are not expecting > page migration to work for their pages. New changes to page migration i > changing that and we now need a flag to explicitly opt-in page migration. > > Changes since v2: > - pr_err() in case of hotplug failure > > Changes since v1: > - Improved commit message > - Improved define name > - Improved comments > - Typos > > Signed-off-by: Jérôme Glisse Fairly minor but it's standard for flags to be unsigned due to uncertainity about what happens when a signed type is bit shifted. May not apply to your case but fairly trivial to address. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 989A76B038E for ; Sun, 19 Mar 2017 16:08:34 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id h188so12899400wma.4 for ; Sun, 19 Mar 2017 13:08:34 -0700 (PDT) Received: from outbound-smtp03.blacknight.com (outbound-smtp03.blacknight.com. [81.17.249.16]) by mx.google.com with ESMTPS id a15si20007853wra.327.2017.03.19.13.08.32 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 Mar 2017 13:08:33 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp03.blacknight.com (Postfix) with ESMTPS id 8A3EC98D0A for ; Sun, 19 Mar 2017 20:08:32 +0000 (UTC) Date: Sun, 19 Mar 2017 20:08:21 +0000 From: Mel Gorman Subject: Re: [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3 Message-ID: <20170319200821.GB2774@techsingularity.net> References: <1489680335-6594-1-git-send-email-jglisse@redhat.com> <1489680335-6594-2-git-send-email-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489680335-6594-2-git-send-email-jglisse@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: J?r?me Glisse Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Naoya Horiguchi , David Nellans , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" On Thu, Mar 16, 2017 at 12:05:20PM -0400, J?r?me Glisse wrote: > When hotpluging memory we want more informations on the type of memory and > its properties. Replace the device boolean flag by an int and define a set > of flags. > > New property for device memory is an opt-in flag to allow page migration > from and to a ZONE_DEVICE. Existing user of ZONE_DEVICE are not expecting > page migration to work for their pages. New changes to page migration i > changing that and we now need a flag to explicitly opt-in page migration. > > Changes since v2: > - pr_err() in case of hotplug failure > > Changes since v1: > - Improved commit message > - Improved define name > - Improved comments > - Typos > > Signed-off-by: Jerome Glisse Fairly minor but it's standard for flags to be unsigned due to uncertainity about what happens when a signed type is bit shifted. May not apply to your case but fairly trivial to address. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org