From: Olivier Matz <olivier.matz@6wind.com>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
dev@dpdk.org, keith.wiles@intel.com,
jerin.jacob@caviumnetworks.com
Subject: Re: [PATCH] mk: optimize directory dependencies
Date: Mon, 20 Mar 2017 09:31:53 +0100 [thread overview]
Message-ID: <20170320093153.2b6f6d99@platinum> (raw)
In-Reply-To: <CA+4wmqyu5Q2=KwBYXG-bHcBwTjRHEvj0YVZst5jnHwLGUnYqrQ@mail.gmail.com>
Hi Robin,
On Fri, 17 Mar 2017 18:47:20 +0100, Robin Jarry <robin.jarry@6wind.com> wrote:
> Hi Olivier,
>
> Thanks again for this. I only have minor cosmetic remarks:
>
> Le 17 mars 2017 18:13, "Olivier Matz" <olivier.matz@6wind.com> a écrit:
> > diff --git a/app/pdump/Makefile b/app/pdump/Makefile
> > index 536198f..8ec6bd6 100644
> > --- a/app/pdump/Makefile
> > +++ b/app/pdump/Makefile
> > @@ -42,7 +42,6 @@ CFLAGS += $(WERROR_FLAGS)
> > SRCS-y := main.c
> >
> > # this application needs libraries first
> > -DEPDIRS-y += lib
> >
> > include $(RTE_SDK)/mk/rte.app.mk
>
> Maybe remove the comment line too?
>
> > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> > index eec1ed0..3be1ae8 100644
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -82,7 +82,6 @@ endif
> > CFLAGS_cmdline.o := -D_GNU_SOURCE
> >
> > # this application needs libraries first
> > -DEPDIRS-y += lib drivers
> >
> > include $(RTE_SDK)/mk/rte.app.mk
>
> Same here. There may be others.
Thanks, I'll check for other occurrences.
> > --- a/mk/rte.subdir.mk
> > +++ b/mk/rte.subdir.mk
> > @@ -59,8 +61,9 @@ build: _postbuild
> > .PHONY: $(DIRS-y)
> > $(DIRS-y):
> > @[ -d $(CURDIR)/$@ ] || mkdir -p $(CURDIR)/$@
> > - @echo "== Build $S/$@"
> > + @echo "== Build $S/$@ "
>
> Why change this line ?
It's a typo, I'll remove it in v2.
Thanks for your review
Olivier
next prev parent reply other threads:[~2017-03-20 8:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 1:50 [PATCH] mk: parallelize make config Ferruh Yigit
2017-01-23 17:18 ` Olivier Matz
2017-01-23 17:19 ` [PATCH] mk: optimize directory dependencies Olivier Matz
2017-01-24 11:19 ` Robin Jarry
2017-01-24 11:26 ` Bruce Richardson
2017-01-24 12:31 ` Robin Jarry
2017-01-24 11:40 ` Jerin Jacob
2017-01-24 12:15 ` Bruce Richardson
2017-01-24 12:56 ` Jerin Jacob
2017-01-24 13:26 ` Richardson, Bruce
2017-01-24 14:50 ` Olivier MATZ
2017-01-24 14:55 ` Wiles, Keith
2017-03-01 11:25 ` Thomas Monjalon
2017-03-01 12:10 ` Bruce Richardson
2017-03-01 12:30 ` Olivier Matz
2017-01-24 13:05 ` Ferruh Yigit
2017-03-17 17:13 ` Olivier Matz
2017-03-17 17:47 ` Robin Jarry
2017-03-20 8:31 ` Olivier Matz [this message]
2017-03-24 13:21 ` [PATCH v2] " Olivier Matz
2017-03-27 21:33 ` Thomas Monjalon
2017-03-28 10:34 ` Ferruh Yigit
2017-03-30 8:51 ` Olivier Matz
2017-03-30 9:27 ` Ferruh Yigit
2017-03-30 12:11 ` Olivier Matz
2017-03-30 12:32 ` [PATCH] mk: fix dependencies to optional configs Olivier Matz
2017-03-30 12:37 ` Ferruh Yigit
2017-03-30 13:37 ` Thomas Monjalon
2017-01-23 17:50 ` [PATCH] mk: parallelize make config Wiles, Keith
2017-01-24 8:42 ` Olivier MATZ
2017-01-24 10:02 ` Bruce Richardson
2017-01-23 19:03 ` Michał Mirosław
2017-01-30 9:41 ` Ferruh Yigit
2017-01-24 10:52 ` Bruce Richardson
2017-01-29 15:29 ` Thomas Monjalon
2017-01-30 9:46 ` Ferruh Yigit
2017-01-30 10:21 ` [PATCH v2] " Ferruh Yigit
2017-01-30 18:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320093153.2b6f6d99@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
--cc=robin.jarry@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.