From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: add qt5virtualkeyboard
Date: Mon, 20 Mar 2017 10:20:05 -0400 [thread overview]
Message-ID: <20170320142005.a6jb32nyfdiypdxd@gportay> (raw)
In-Reply-To: <20170318152235.0be2d895@free-electrons.com>
Hi Thomas,
On Sat, Mar 18, 2017 at 03:22:35PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> Peter, could you help by reviewing this patch touching qt5 stuff?
>
> Thanks a lot!
>
> Thomas
>
> On Fri, 17 Mar 2017 12:46:28 -0400, Ga?l PORTAY wrote:
> > This patch adds the Qt virtualkeyboard package.
> >
> > Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> > ---
> > package/qt5/Config.in | 1 +
> > package/qt5/qt5virtualkeyboard/Config.in | 9 +++++++
> > .../qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk | 31 ++++++++++++++++++++++
> > 3 files changed, 41 insertions(+)
> > create mode 100644 package/qt5/qt5virtualkeyboard/Config.in
> > create mode 100644 package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
Oops, the hash file is missing here...
> >
> > diff --git a/package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk b/package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
> > new file mode 100644
> > index 0000000..e73a154
> > --- /dev/null
> > +++ b/package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
> > @@ -0,0 +1,31 @@
> > +################################################################################
> > +#
> > +# qt5virtualkeyboard
> > +#
> > +################################################################################
> > +
> > +QT5VIRTUALKEYBOARD_VERSION = $(QT5_VERSION)
> > +QT5VIRTUALKEYBOARD_SITE = $(QT5_SITE)
> > +QT5VIRTUALKEYBOARD_SOURCE = qtvirtualkeyboard-opensource-src-$(QT5VIRTUALKEYBOARD_VERSION).tar.xz
> > +QT5VIRTUALKEYBOARD_DEPENDENCIES = qt5base qt5declarative qt5svg
> > +QT5VIRTUALKEYBOARD_INSTALL_STAGING = YES
> > +
Here, I think I should also add this if statement about license:
ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
> > +QT5VIRTUALKEYBOARD_LICENSE = GPLv3
> > +QT5VIRTUALKEYBOARD_LICENSE_FILES = LICENSE.GPL3
else
QT5VIRTUALKEYBOARD_LICENSE = Commercial license
QT5VIRTUALKEYBOARD_LICENSE_FILES = NO
endif
> > +define QT5VIRTUALKEYBOARD_CONFIGURE_CMDS
> > + (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
> > +endef
> > +
> > +define QT5VIRTUALKEYBOARD_BUILD_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> > +endef
> > +
> > +define QT5VIRTUALKEYBOARD_INSTALL_STAGING_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
> > +endef
> > +
> > +define QT5VIRTUALKEYBOARD_INSTALL_TARGET_CMDS
> > + cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick/VirtualKeyboard $(TARGET_DIR)/usr/qml/QtQuick
> > +endef
> > +
> > +$(eval $(generic-package))
>
Also, I am working of installing language layouts.
For now, Chinese, Korean and Japanese layouts do no work properly; others are
fined.
About the integration of a selection of layouts, I cannot make the decision
between a select or a string kconfig entry. I think the string entry has the
advantage to not to have to maintain a hardcoded list; this list would evoluate
between Qt versions...
Would you prefer a select or a string?
Regards,
Gael
next prev parent reply other threads:[~2017-03-20 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 16:46 [Buildroot] [PATCH] package: add qt5virtualkeyboard Gaël PORTAY
2017-03-18 14:22 ` Thomas Petazzoni
2017-03-20 14:20 ` Gaël PORTAY [this message]
2017-03-20 14:46 ` Thomas Petazzoni
2017-03-20 20:33 ` Peter Seiderer
2017-03-21 13:52 ` Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320142005.a6jb32nyfdiypdxd@gportay \
--to=gael.portay@savoirfairelinux.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.