From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754743AbdCTPNE (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Mar 2017 11:13:04 -0400
Received: from foss.arm.com ([217.140.101.70]:40432 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754301AbdCTPLA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Mar 2017 11:11:00 -0400
Date: Mon, 20 Mar 2017 15:00:55 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Scott Wood <oss@buserror.net>, Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Ding Tianhong <dingtianhong@huawei.com>
Subject: Re: [PATCH 17/17] arm64: arch_timer: Add HISILICON_ERRATUM_161010101
 ACPI matching data
Message-ID: <20170320150055.GJ31213@leverpostej>
References: <20170306112622.13853-1-marc.zyngier@arm.com>
 <20170306112622.13853-18-marc.zyngier@arm.com>
 <13e4473e-e1ec-c193-4d5a-63787d149dda@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13e4473e-e1ec-c193-4d5a-63787d149dda@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 07, 2017 at 09:19:21PM +0800, Hanjun Guo wrote:
> On 2017/3/6 19:26, Marc Zyngier wrote:
> >In order to deal with ACPI enabled platforms suffering from the
> >HISILICON_ERRATUM_161010101, let's add the required OEM data that
> >allow the workaround to be enabled.
> >
> >Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >---
> > drivers/clocksource/arm_arch_timer.c | 29 +++++++++++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> >diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> >index 6182871af4eb..b46584f058b6 100644
> >--- a/drivers/clocksource/arm_arch_timer.c
> >+++ b/drivers/clocksource/arm_arch_timer.c
> >@@ -270,6 +270,25 @@ static u64 notrace hisi_161010101_read_cntvct_el0(void)
> > {
> > 	return __hisi_161010101_read_reg(cntvct_el0);
> > }
> >+
> >+static struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
> >+	{
> >+		.oem_id		= "HISI  ",
> >+		.oem_table_id	= "HIP05   ",
> >+		.oem_revision	= 0,
> >+	},
> >+	{
> >+		.oem_id		= "HISI  ",
> >+		.oem_table_id	= "HIP06   ",
> >+		.oem_revision	= 0,
> >+	},
> >+	{
> >+		.oem_id		= "HISI  ",
> >+		.oem_table_id	= "HIP07   ",
> >+		.oem_revision	= 0,
> >+	},
> >+	{ },
> 
> Maybe it's better to add a comments that to say "It's needed to match
> the end of oem info", but it's up to you :)

Indeed. A comment as to why the sapces are necessary would be very
helpful.

Thanks,
Mark.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: mark.rutland@arm.com (Mark Rutland)
Date: Mon, 20 Mar 2017 15:00:55 +0000
Subject: [PATCH 17/17] arm64: arch_timer: Add HISILICON_ERRATUM_161010101
 ACPI matching data
In-Reply-To: <13e4473e-e1ec-c193-4d5a-63787d149dda@linaro.org>
References: <20170306112622.13853-1-marc.zyngier@arm.com>
 <20170306112622.13853-18-marc.zyngier@arm.com>
 <13e4473e-e1ec-c193-4d5a-63787d149dda@linaro.org>
Message-ID: <20170320150055.GJ31213@leverpostej>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, Mar 07, 2017 at 09:19:21PM +0800, Hanjun Guo wrote:
> On 2017/3/6 19:26, Marc Zyngier wrote:
> >In order to deal with ACPI enabled platforms suffering from the
> >HISILICON_ERRATUM_161010101, let's add the required OEM data that
> >allow the workaround to be enabled.
> >
> >Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >---
> > drivers/clocksource/arm_arch_timer.c | 29 +++++++++++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> >diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> >index 6182871af4eb..b46584f058b6 100644
> >--- a/drivers/clocksource/arm_arch_timer.c
> >+++ b/drivers/clocksource/arm_arch_timer.c
> >@@ -270,6 +270,25 @@ static u64 notrace hisi_161010101_read_cntvct_el0(void)
> > {
> > 	return __hisi_161010101_read_reg(cntvct_el0);
> > }
> >+
> >+static struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
> >+	{
> >+		.oem_id		= "HISI  ",
> >+		.oem_table_id	= "HIP05   ",
> >+		.oem_revision	= 0,
> >+	},
> >+	{
> >+		.oem_id		= "HISI  ",
> >+		.oem_table_id	= "HIP06   ",
> >+		.oem_revision	= 0,
> >+	},
> >+	{
> >+		.oem_id		= "HISI  ",
> >+		.oem_table_id	= "HIP07   ",
> >+		.oem_revision	= 0,
> >+	},
> >+	{ },
> 
> Maybe it's better to add a comments that to say "It's needed to match
> the end of oem info", but it's up to you :)

Indeed. A comment as to why the sapces are necessary would be very
helpful.

Thanks,
Mark.