All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV
@ 2017-03-03 15:19 ville.syrjala
  2017-03-03 15:19 ` [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible() ville.syrjala
                   ` (9 more replies)
  0 siblings, 10 replies; 19+ messages in thread
From: ville.syrjala @ 2017-03-03 15:19 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

With the watermarks properly handled everything should be in place
to make VLV/CHV nuclear. Just to be super safe I included a few
extra bits of polish to the cursor handling.

Ville Syrjälä (4):
  drm/i915: Extract intel_wm_plane_visible()
  drm/i915: Check for id==PLANE_CURSOR instead of
    type==DRM_PLANE_TYPE_CURSOR
  drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
  drm/i915: Enable atomic on VLV/CHV

 drivers/gpu/drm/i915/i915_drv.c |  5 ++---
 drivers/gpu/drm/i915/intel_pm.c | 45 +++++++++++++++++++++++++++--------------
 2 files changed, 32 insertions(+), 18 deletions(-)

-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible()
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
@ 2017-03-03 15:19 ` ville.syrjala
  2017-03-17 19:52   ` Chris Wilson
  2017-03-03 15:19 ` [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR ville.syrjala
                   ` (8 subsequent siblings)
  9 siblings, 1 reply; 19+ messages in thread
From: ville.syrjala @ 2017-03-03 15:19 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

All platforms that lack double buffered watermarks will need to
handle the legacy cursor updates in the same way. So let's extract the
logic to determine the plane visibility into a small helper. For
simplicity we'll make the function DTRT for any plane, but only apply
the special sauce for cursor planes.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 39 +++++++++++++++++++++++++++------------
 1 file changed, 27 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 99e09f63d4b3..54d211d0d29e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -655,6 +655,29 @@ static unsigned long intel_calculate_wm(unsigned long clock_in_khz,
 	return wm_size;
 }
 
+static bool intel_wm_plane_visible(const struct intel_crtc_state *crtc_state,
+				   const struct intel_plane_state *plane_state)
+{
+	struct intel_plane *plane = to_intel_plane(plane_state->base.plane);
+
+	/* FIXME check the 'enable' instead */
+	if (!crtc_state->base.active)
+		return false;
+
+	/*
+	 * Treat cursor with fb as always visible since cursor updates
+	 * can happen faster than the vrefresh rate, and the current
+	 * watermark code doesn't handle that correctly. Cursor updates
+	 * which set/clear the fb or change the cursor size are going
+	 * to get throttled by intel_legacy_cursor_update() to work
+	 * around this problem with the watermark code.
+	 */
+	if (plane->id == PLANE_CURSOR)
+		return plane_state->base.fb != NULL;
+	else
+		return plane_state->base.visible;
+}
+
 static struct intel_crtc *single_enabled_crtc(struct drm_i915_private *dev_priv)
 {
 	struct intel_crtc *crtc, *enabled = NULL;
@@ -1952,7 +1975,7 @@ static uint32_t ilk_compute_pri_wm(const struct intel_crtc_state *cstate,
 	uint32_t method1, method2;
 	int cpp;
 
-	if (!cstate->base.active || !pstate->base.visible)
+	if (!intel_wm_plane_visible(cstate, pstate))
 		return 0;
 
 	cpp = pstate->base.fb->format->cpp[0];
@@ -1981,7 +2004,7 @@ static uint32_t ilk_compute_spr_wm(const struct intel_crtc_state *cstate,
 	uint32_t method1, method2;
 	int cpp;
 
-	if (!cstate->base.active || !pstate->base.visible)
+	if (!intel_wm_plane_visible(cstate, pstate))
 		return 0;
 
 	cpp = pstate->base.fb->format->cpp[0];
@@ -2004,15 +2027,7 @@ static uint32_t ilk_compute_cur_wm(const struct intel_crtc_state *cstate,
 {
 	int cpp;
 
-	/*
-	 * Treat cursor with fb as always visible since cursor updates
-	 * can happen faster than the vrefresh rate, and the current
-	 * watermark code doesn't handle that correctly. Cursor updates
-	 * which set/clear the fb or change the cursor size are going
-	 * to get throttled by intel_legacy_cursor_update() to work
-	 * around this problem with the watermark code.
-	 */
-	if (!cstate->base.active || !pstate->base.fb)
+	if (!intel_wm_plane_visible(cstate, pstate))
 		return 0;
 
 	cpp = pstate->base.fb->format->cpp[0];
@@ -2029,7 +2044,7 @@ static uint32_t ilk_compute_fbc_wm(const struct intel_crtc_state *cstate,
 {
 	int cpp;
 
-	if (!cstate->base.active || !pstate->base.visible)
+	if (!intel_wm_plane_visible(cstate, pstate))
 		return 0;
 
 	cpp = pstate->base.fb->format->cpp[0];
-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
  2017-03-03 15:19 ` [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible() ville.syrjala
@ 2017-03-03 15:19 ` ville.syrjala
  2017-03-17 19:54   ` Chris Wilson
  2017-03-17 19:56   ` Chris Wilson
  2017-03-03 15:19 ` [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well ville.syrjala
                   ` (7 subsequent siblings)
  9 siblings, 2 replies; 19+ messages in thread
From: ville.syrjala @ 2017-03-03 15:19 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The VLV/CHV watermark calculation is really interested in the hardware
plane type rather than the plane type (which is more of a software
concept). Let's check plane->id rather plane->type.

No functional changes.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 54d211d0d29e..70eca32e4036 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -1039,7 +1039,7 @@ static uint16_t vlv_compute_wm_level(const struct intel_crtc_state *crtc_state,
 	if (WARN_ON(htotal == 0))
 		htotal = 1;
 
-	if (plane->base.type == DRM_PLANE_TYPE_CURSOR) {
+	if (plane->id == PLANE_CURSOR) {
 		/*
 		 * FIXME the formula gives values that are
 		 * too big for the cursor FIFO, and hence we
-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
  2017-03-03 15:19 ` [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible() ville.syrjala
  2017-03-03 15:19 ` [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR ville.syrjala
@ 2017-03-03 15:19 ` ville.syrjala
  2017-03-17 19:55   ` Chris Wilson
  2017-03-03 15:19 ` [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV ville.syrjala
                   ` (6 subsequent siblings)
  9 siblings, 1 reply; 19+ messages in thread
From: ville.syrjala @ 2017-03-03 15:19 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

VLV/CHV don't have double buffered watermarks so they need to consider
the cursor visibility as a special case just like ILK-BDW. Let's use
the helper we have for that.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 70eca32e4036..8c2656bceb4e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -1029,7 +1029,7 @@ static uint16_t vlv_compute_wm_level(const struct intel_crtc_state *crtc_state,
 	if (dev_priv->wm.pri_latency[level] == 0)
 		return USHRT_MAX;
 
-	if (!plane_state->base.visible)
+	if (!intel_wm_plane_visible(crtc_state, plane_state))
 		return 0;
 
 	cpp = plane_state->base.fb->format->cpp[0];
@@ -1203,7 +1203,7 @@ static bool vlv_plane_wm_compute(struct intel_crtc_state *crtc_state,
 	int level;
 	bool dirty = false;
 
-	if (!plane_state->base.visible) {
+	if (!intel_wm_plane_visible(crtc_state, plane_state)) {
 		dirty |= vlv_raw_plane_wm_set(crtc_state, 0, plane_id, 0);
 		goto out;
 	}
-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (2 preceding siblings ...)
  2017-03-03 15:19 ` [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well ville.syrjala
@ 2017-03-03 15:19 ` ville.syrjala
  2017-03-06  7:05   ` Maarten Lankhorst
  2017-03-03 16:47 ` ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV Patchwork
                   ` (5 subsequent siblings)
  9 siblings, 1 reply; 19+ messages in thread
From: ville.syrjala @ 2017-03-03 15:19 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

VLV/CHV watermarks are now able to handle the radiation, so
mark these platforms as ready for atomic.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Suggested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index b1e9027a4f80..c8944bf65a36 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1214,9 +1214,8 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
 	struct drm_i915_private *dev_priv;
 	int ret;
 
-	/* Enable nuclear pageflip on ILK+, except vlv/chv */
-	if (!i915.nuclear_pageflip &&
-	    (match_info->gen < 5 || match_info->has_gmch_display))
+	/* Enable nuclear pageflip on ILK+ */
+	if (!i915.nuclear_pageflip && match_info->gen < 5)
 		driver.driver_features &= ~DRIVER_ATOMIC;
 
 	ret = -ENOMEM;
-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (3 preceding siblings ...)
  2017-03-03 15:19 ` [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV ville.syrjala
@ 2017-03-03 16:47 ` Patchwork
  2017-03-03 19:17   ` Ville Syrjälä
  2017-03-06 15:48 ` Patchwork
                   ` (4 subsequent siblings)
  9 siblings, 1 reply; 19+ messages in thread
From: Patchwork @ 2017-03-03 16:47 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Enable atomic for VLV/CHV
URL   : https://patchwork.freedesktop.org/series/20634/
State : failure

== Summary ==

Series 20634v1 drm/i915: Enable atomic for VLV/CHV
https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/

Test drv_module_reload:
        Subgroup basic-reload-final:
                pass       -> DMESG-WARN (fi-skl-6770hq)
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-byt-j1900)
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-byt-j1900)
        Subgroup basic-flip-after-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-byt-j1900)
        Subgroup basic-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820)

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11 
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36 
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19 
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20 
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24 
fi-byt-n2820     total:278  pass:242  dwarn:0   dfail:0   fail:8   skip:28 
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16 
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16 
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50 
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18 
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18 
fi-kbl-7500u     total:278  pass:259  dwarn:1   dfail:0   fail:0   skip:18 
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10 
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17 
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18 
fi-skl-6770hq    total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10 
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28 
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29 

1d7915e7823628a0d548c6ecc5ad5b9a4ae4a6ff drm-tip: 2017y-03m-03d-15h-54m-06s UTC integration manifest
e288b5f drm/i915: Enable atomic on VLV/CHV
f58f60d drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
26ed515 drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
a6d3070 drm/i915: Extract intel_wm_plane_visible()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4056/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 16:47 ` ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV Patchwork
@ 2017-03-03 19:17   ` Ville Syrjälä
  0 siblings, 0 replies; 19+ messages in thread
From: Ville Syrjälä @ 2017-03-03 19:17 UTC (permalink / raw)
  To: intel-gfx

On Fri, Mar 03, 2017 at 04:47:28PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Enable atomic for VLV/CHV
> URL   : https://patchwork.freedesktop.org/series/20634/
> State : failure
> 
> == Summary ==
> 
> Series 20634v1 drm/i915: Enable atomic for VLV/CHV
> https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/
> 
> Test drv_module_reload:
>         Subgroup basic-reload-final:
>                 pass       -> DMESG-WARN (fi-skl-6770hq)
> Test kms_cursor_legacy:
>         Subgroup basic-busy-flip-before-cursor-atomic:
>                 skip       -> PASS       (fi-bsw-n3050)
>                 skip       -> FAIL       (fi-byt-n2820)
>                 skip       -> PASS       (fi-byt-j1900)
>         Subgroup basic-busy-flip-before-cursor-legacy:
>                 pass       -> FAIL       (fi-byt-n2820)
>         Subgroup basic-flip-after-cursor-atomic:
>                 skip       -> PASS       (fi-bsw-n3050)
>                 skip       -> FAIL       (fi-byt-n2820)
>                 skip       -> PASS       (fi-byt-j1900)
>         Subgroup basic-flip-after-cursor-legacy:
>                 pass       -> FAIL       (fi-byt-n2820)
>         Subgroup basic-flip-after-cursor-varying-size:
>                 pass       -> FAIL       (fi-byt-n2820)
>         Subgroup basic-flip-before-cursor-atomic:
>                 skip       -> PASS       (fi-bsw-n3050)
>                 skip       -> FAIL       (fi-byt-n2820)
>                 skip       -> PASS       (fi-byt-j1900)
>         Subgroup basic-flip-before-cursor-legacy:
>                 pass       -> FAIL       (fi-byt-n2820)
>         Subgroup basic-flip-before-cursor-varying-size:
>                 pass       -> FAIL       (fi-byt-n2820)

Hmm. I wonder what's bogging that guy down. This seems to pass on my
n2820 just fine.

> 
> fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11 
> fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36 
> fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19 
> fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20 
> fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24 
> fi-byt-n2820     total:278  pass:242  dwarn:0   dfail:0   fail:8   skip:28 
> fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16 
> fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16 
> fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50 
> fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18 
> fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18 
> fi-kbl-7500u     total:278  pass:259  dwarn:1   dfail:0   fail:0   skip:18 
> fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10 
> fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17 
> fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18 
> fi-skl-6770hq    total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10 
> fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28 
> fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29 
> 
> 1d7915e7823628a0d548c6ecc5ad5b9a4ae4a6ff drm-tip: 2017y-03m-03d-15h-54m-06s UTC integration manifest
> e288b5f drm/i915: Enable atomic on VLV/CHV
> f58f60d drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
> 26ed515 drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
> a6d3070 drm/i915: Extract intel_wm_plane_visible()
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4056/

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV
  2017-03-03 15:19 ` [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV ville.syrjala
@ 2017-03-06  7:05   ` Maarten Lankhorst
  0 siblings, 0 replies; 19+ messages in thread
From: Maarten Lankhorst @ 2017-03-06  7:05 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx

Op 03-03-17 om 16:19 schreef ville.syrjala@linux.intel.com:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> VLV/CHV watermarks are now able to handle the radiation, so
> mark these platforms as ready for atomic.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Suggested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index b1e9027a4f80..c8944bf65a36 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1214,9 +1214,8 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	struct drm_i915_private *dev_priv;
>  	int ret;
>  
> -	/* Enable nuclear pageflip on ILK+, except vlv/chv */
> -	if (!i915.nuclear_pageflip &&
> -	    (match_info->gen < 5 || match_info->has_gmch_display))
> +	/* Enable nuclear pageflip on ILK+ */
> +	if (!i915.nuclear_pageflip && match_info->gen < 5)
>  		driver.driver_features &= ~DRIVER_ATOMIC;
>  
>  	ret = -ENOMEM;

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (4 preceding siblings ...)
  2017-03-03 16:47 ` ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV Patchwork
@ 2017-03-06 15:48 ` Patchwork
  2017-03-15 17:29 ` Patchwork
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2017-03-06 15:48 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Enable atomic for VLV/CHV
URL   : https://patchwork.freedesktop.org/series/20634/
State : failure

== Summary ==

Series 20634v1 drm/i915: Enable atomic for VLV/CHV
https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/

Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (fi-skl-6770hq) fdo#99739

fdo#99739 https://bugs.freedesktop.org/show_bug.cgi?id=99739

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time: 462s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time: 544s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time: 610s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time: 504s
fi-byt-n2820     total:278  pass:242  dwarn:0   dfail:0   fail:8   skip:28  time: 508s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 439s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 435s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time: 449s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 506s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 486s
fi-kbl-7500u     total:278  pass:259  dwarn:1   dfail:0   fail:0   skip:18  time: 487s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 508s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time: 593s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time: 505s
fi-skl-6770hq    total:278  pass:267  dwarn:0   dfail:0   fail:1   skip:10  time: 531s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time: 560s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time: 423s

e06000745435e65b4c056fe8f5bf149b298a0526 drm-tip: 2017y-03m-06d-14h-39m-38s UTC integration manifest
0cb9cb1 drm/i915: Enable atomic on VLV/CHV
29bed26 drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
051abdd drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
40e179c drm/i915: Extract intel_wm_plane_visible()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4072/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (5 preceding siblings ...)
  2017-03-06 15:48 ` Patchwork
@ 2017-03-15 17:29 ` Patchwork
  2017-03-20 19:00 ` Patchwork
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2017-03-15 17:29 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Enable atomic for VLV/CHV
URL   : https://patchwork.freedesktop.org/series/20634/
State : failure

== Summary ==

Series 20634v1 drm/i915: Enable atomic for VLV/CHV
https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                pass       -> INCOMPLETE (fi-skl-6700hq) fdo#100130
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-bsw-n3050)
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-bsw-n3050)
        Subgroup basic-flip-after-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-bsw-n3050)
        Subgroup basic-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094

fdo#100130 https://bugs.freedesktop.org/show_bug.cgi?id=100130
fdo#100094 https://bugs.freedesktop.org/show_bug.cgi?id=100094

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time: 469s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time: 574s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time: 536s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time: 570s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time: 503s
fi-byt-n2820     total:278  pass:242  dwarn:0   dfail:0   fail:8   skip:28  time: 501s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 436s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 430s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time: 440s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 515s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 499s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 492s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 485s
fi-skl-6700hq    total:51   pass:43   dwarn:0   dfail:0   fail:0   skip:7   time: 0s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time: 482s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 513s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time: 552s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time: 425s

9a2b1c7caa7c45e1ec5ae6183a70a2d259101f2e drm-tip: 2017y-03m-15d-15h-52m-11s UTC integration manifest
0458de5 drm/i915: Enable atomic on VLV/CHV
7908d36 drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
ca8fb7b drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
5909133 drm/i915: Extract intel_wm_plane_visible()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4185/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible()
  2017-03-03 15:19 ` [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible() ville.syrjala
@ 2017-03-17 19:52   ` Chris Wilson
  0 siblings, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2017-03-17 19:52 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

On Fri, Mar 03, 2017 at 05:19:25PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> All platforms that lack double buffered watermarks will need to
> handle the legacy cursor updates in the same way. So let's extract the
> logic to determine the plane visibility into a small helper. For
> simplicity we'll make the function DTRT for any plane, but only apply
> the special sauce for cursor planes.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
  2017-03-03 15:19 ` [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR ville.syrjala
@ 2017-03-17 19:54   ` Chris Wilson
  2017-03-17 20:01     ` Ville Syrjälä
  2017-03-17 19:56   ` Chris Wilson
  1 sibling, 1 reply; 19+ messages in thread
From: Chris Wilson @ 2017-03-17 19:54 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

On Fri, Mar 03, 2017 at 05:19:26PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The VLV/CHV watermark calculation is really interested in the hardware
> plane type rather than the plane type (which is more of a software
> concept). Let's check plane->id rather plane->type.
> 
> No functional changes.

When will they differ? Is this for multipurpose planes, such as a sprite
that we treat as a cursor for simplicity?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
  2017-03-03 15:19 ` [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well ville.syrjala
@ 2017-03-17 19:55   ` Chris Wilson
  0 siblings, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2017-03-17 19:55 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

On Fri, Mar 03, 2017 at 05:19:27PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> VLV/CHV don't have double buffered watermarks so they need to consider
> the cursor visibility as a special case just like ILK-BDW. Let's use
> the helper we have for that.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Convinced,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
  2017-03-03 15:19 ` [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR ville.syrjala
  2017-03-17 19:54   ` Chris Wilson
@ 2017-03-17 19:56   ` Chris Wilson
  1 sibling, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2017-03-17 19:56 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

On Fri, Mar 03, 2017 at 05:19:26PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The VLV/CHV watermark calculation is really interested in the hardware
> plane type rather than the plane type (which is more of a software
> concept). Let's check plane->id rather plane->type.
> 
> No functional changes.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 54d211d0d29e..70eca32e4036 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -1039,7 +1039,7 @@ static uint16_t vlv_compute_wm_level(const struct intel_crtc_state *crtc_state,
>  	if (WARN_ON(htotal == 0))
>  		htotal = 1;
>  
> -	if (plane->base.type == DRM_PLANE_TYPE_CURSOR) {
> +	if (plane->id == PLANE_CURSOR) {

Ok, this is bring this piece of code into line with everyone else,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
  2017-03-17 19:54   ` Chris Wilson
@ 2017-03-17 20:01     ` Ville Syrjälä
  0 siblings, 0 replies; 19+ messages in thread
From: Ville Syrjälä @ 2017-03-17 20:01 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On Fri, Mar 17, 2017 at 07:54:30PM +0000, Chris Wilson wrote:
> On Fri, Mar 03, 2017 at 05:19:26PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > The VLV/CHV watermark calculation is really interested in the hardware
> > plane type rather than the plane type (which is more of a software
> > concept). Let's check plane->id rather plane->type.
> > 
> > No functional changes.
> 
> When will they differ? Is this for multipurpose planes, such as a sprite
> that we treat as a cursor for simplicity?

Yeah. Currently they never differ, but just in case someone ever decides
to break that relationship I figured it's better to be clear on which kind
of hardware plane we're dealing with.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (6 preceding siblings ...)
  2017-03-15 17:29 ` Patchwork
@ 2017-03-20 19:00 ` Patchwork
  2017-03-21 14:31 ` Patchwork
  2017-04-04 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
  9 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2017-03-20 19:00 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Enable atomic for VLV/CHV
URL   : https://patchwork.freedesktop.org/series/20634/
State : failure

== Summary ==

Series 20634v1 drm/i915: Enable atomic for VLV/CHV
https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                fail       -> PASS       (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> PASS       (fi-byt-j1900)
                skip       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-before-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> INCOMPLETE (fi-byt-n2820)
        Subgroup basic-plain-flip:
                pass       -> INCOMPLETE (fi-byt-j1900)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-c:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup nonblocking-crc-pipe-b:
                pass       -> INCOMPLETE (fi-bxt-j4205)
Test kms_setmode:
        Subgroup basic-clone-single-crtc:
                pass       -> INCOMPLETE (fi-bsw-n3050)
Test pm_backlight:
        Subgroup basic-brightness:
                pass       -> INCOMPLETE (fi-snb-2520m)

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100094 https://bugs.freedesktop.org/show_bug.cgi?id=100094

fi-bdw-5557u     total:300  pass:284  dwarn:0   dfail:0   fail:0   skip:16  time: 619s
fi-bsw-n3050     total:300  pass:223  dwarn:0   dfail:0   fail:1   skip:41  time: 0s
fi-bxt-j4205     total:300  pass:231  dwarn:0   dfail:0   fail:3   skip:19  time: 0s
fi-byt-j1900     total:237  pass:214  dwarn:0   dfail:0   fail:0   skip:22  time: 0s
fi-byt-n2820     total:300  pass:203  dwarn:0   dfail:0   fail:8   skip:26  time: 0s
fi-hsw-4770      total:300  pass:279  dwarn:0   dfail:0   fail:1   skip:20  time: 660s
fi-ilk-650       total:300  pass:240  dwarn:0   dfail:0   fail:2   skip:58  time: 533s
fi-ivb-3520m     total:263  pass:238  dwarn:0   dfail:0   fail:5   skip:19  time: 0s
fi-kbl-7500u     total:300  pass:275  dwarn:1   dfail:0   fail:4   skip:20  time: 634s
fi-skl-6260u     total:300  pass:283  dwarn:1   dfail:0   fail:4   skip:12  time: 646s
fi-skl-6700k     total:300  pass:271  dwarn:5   dfail:0   fail:4   skip:20  time: 667s
fi-skl-6770hq    total:300  pass:283  dwarn:1   dfail:0   fail:4   skip:12  time: 696s
fi-snb-2520m     total:300  pass:227  dwarn:0   dfail:0   fail:6   skip:33  time: 0s
fi-snb-2600      total:300  pass:258  dwarn:0   dfail:0   fail:6   skip:36  time: 586s
fi-hsw-4770r failed to connect after reboot
fi-skl-6700hq failed to connect after reboot

a4d4230315e8bd8ce20fc86d860ec342c630da65 drm-tip: 2017y-03m-20d-14h-40m-55s UTC integration manifest
a58a5bd drm/i915: Enable atomic on VLV/CHV
0521fa8 drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
0c5b12f drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
f821f04 drm/i915: Extract intel_wm_plane_visible()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4234/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (7 preceding siblings ...)
  2017-03-20 19:00 ` Patchwork
@ 2017-03-21 14:31 ` Patchwork
  2017-04-04 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
  9 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2017-03-21 14:31 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Enable atomic for VLV/CHV
URL   : https://patchwork.freedesktop.org/series/20634/
State : failure

== Summary ==

Series 20634v1 drm/i915: Enable atomic for VLV/CHV
https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/

Test gem_exec_fence:
        Subgroup await-hang-default:
                pass       -> INCOMPLETE (fi-hsw-4770)
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-byt-j1900)
                skip       -> PASS       (fi-bsw-n3050)
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-byt-j1900)
                skip       -> PASS       (fi-bsw-n3050)
        Subgroup basic-flip-after-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820)
        Subgroup basic-flip-after-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> FAIL       (fi-byt-n2820)
                skip       -> PASS       (fi-byt-j1900)
                skip       -> PASS       (fi-bsw-n3050)
        Subgroup basic-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094
        Subgroup basic-flip-before-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100094

fdo#100094 https://bugs.freedesktop.org/show_bug.cgi?id=100094

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time: 464s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time: 579s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time: 533s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time: 504s
fi-byt-n2820     total:278  pass:242  dwarn:0   dfail:0   fail:8   skip:28  time: 506s
fi-hsw-4770      total:48   pass:41   dwarn:0   dfail:0   fail:0   skip:6   time: 0s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 432s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time: 432s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 517s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 493s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 475s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 483s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time: 604s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time: 484s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 519s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time: 548s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time: 415s
fi-bxt-t5700 failed to connect after reboot

84b98c6d4f5f6ce0ce17b8fd07629dfc71e7d829 drm-tip: 2017y-03m-21d-11h-08m-23s UTC integration manifest
d719fe6 drm/i915: Enable atomic on VLV/CHV
a644fd8 drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
85eca21 drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
21dae64 drm/i915: Extract intel_wm_plane_visible()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4248/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915: Enable atomic for VLV/CHV
  2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
                   ` (8 preceding siblings ...)
  2017-03-21 14:31 ` Patchwork
@ 2017-04-04 17:34 ` Patchwork
  2017-04-05 10:30   ` Ville Syrjälä
  9 siblings, 1 reply; 19+ messages in thread
From: Patchwork @ 2017-04-04 17:34 UTC (permalink / raw)
  To: ville.syrjala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Enable atomic for VLV/CHV
URL   : https://patchwork.freedesktop.org/series/20634/
State : success

== Summary ==

Series 20634v1 drm/i915: Enable atomic for VLV/CHV
https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/

Test gem_busy:
        Subgroup basic-hang-default:
                incomplete -> PASS       (fi-hsw-4770r) fdo#100561
Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                pass       -> FAIL       (fi-snb-2600) fdo#100007
Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                dmesg-warn -> PASS       (fi-bxt-t5700) fdo#100125
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> PASS       (fi-byt-n2820) fdo#100415
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> PASS       (fi-byt-n2820) fdo#100415
        Subgroup basic-flip-after-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100415
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> PASS       (fi-byt-j1900)
                skip       -> PASS       (fi-bsw-n3050)
                skip       -> PASS       (fi-byt-n2820) fdo#100415
        Subgroup basic-flip-before-cursor-varying-size:
                pass       -> FAIL       (fi-byt-n2820) fdo#100415
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                dmesg-warn -> PASS       (fi-byt-n2820) fdo#100094

fdo#100561 https://bugs.freedesktop.org/show_bug.cgi?id=100561
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#100415 https://bugs.freedesktop.org/show_bug.cgi?id=100415
fdo#100094 https://bugs.freedesktop.org/show_bug.cgi?id=100094

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time: 434s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time: 426s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time: 576s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time: 514s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time: 547s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time: 485s
fi-byt-n2820     total:278  pass:248  dwarn:0   dfail:0   fail:2   skip:28  time: 491s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 411s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 405s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time: 422s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 490s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 488s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 459s
fi-kbl-7560u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 564s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 453s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time: 575s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time: 454s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 490s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time: 431s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time: 526s
fi-snb-2600      total:278  pass:248  dwarn:0   dfail:0   fail:1   skip:29  time: 403s

5467cb1fdc74248d650217938305b8f51a0af3f8 drm-tip: 2017y-04m-04d-16h-54m-17s UTC integration manifest
d6807fd5 drm/i915: Enable atomic on VLV/CHV
7e86af5 drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
d300717 drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4398/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: ✓ Fi.CI.BAT: success for drm/i915: Enable atomic for VLV/CHV
  2017-04-04 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-04-05 10:30   ` Ville Syrjälä
  0 siblings, 0 replies; 19+ messages in thread
From: Ville Syrjälä @ 2017-04-05 10:30 UTC (permalink / raw)
  To: intel-gfx

On Tue, Apr 04, 2017 at 05:34:17PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Enable atomic for VLV/CHV
> URL   : https://patchwork.freedesktop.org/series/20634/
> State : success
> 
> == Summary ==
> 
> Series 20634v1 drm/i915: Enable atomic for VLV/CHV
> https://patchwork.freedesktop.org/api/1.0/series/20634/revisions/1/mbox/
> 
> Test gem_busy:
>         Subgroup basic-hang-default:
>                 incomplete -> PASS       (fi-hsw-4770r) fdo#100561
> Test gem_exec_flush:
>         Subgroup basic-batch-kernel-default-uc:
>                 pass       -> FAIL       (fi-snb-2600) fdo#100007
> Test gem_exec_suspend:
>         Subgroup basic-s4-devices:
>                 dmesg-warn -> PASS       (fi-bxt-t5700) fdo#100125
> Test kms_cursor_legacy:
>         Subgroup basic-busy-flip-before-cursor-atomic:
>                 skip       -> PASS       (fi-byt-j1900)
>                 skip       -> PASS       (fi-bsw-n3050)
>                 skip       -> PASS       (fi-byt-n2820) fdo#100415
>         Subgroup basic-flip-after-cursor-atomic:
>                 skip       -> PASS       (fi-byt-j1900)
>                 skip       -> PASS       (fi-bsw-n3050)
>                 skip       -> PASS       (fi-byt-n2820) fdo#100415
>         Subgroup basic-flip-after-cursor-varying-size:
>                 pass       -> FAIL       (fi-byt-n2820) fdo#100415
>         Subgroup basic-flip-before-cursor-atomic:
>                 skip       -> PASS       (fi-byt-j1900)
>                 skip       -> PASS       (fi-bsw-n3050)
>                 skip       -> PASS       (fi-byt-n2820) fdo#100415
>         Subgroup basic-flip-before-cursor-varying-size:
>                 pass       -> FAIL       (fi-byt-n2820) fdo#100415

OK, so we're just down to the varying-size tests not passing
on fi-byt-n2820, so I'm going to declare victory.

Rest of the series pushed to dinq. Thanks for the review.

> Test kms_pipe_crc_basic:
>         Subgroup nonblocking-crc-pipe-a-frame-sequence:
>                 dmesg-warn -> PASS       (fi-byt-n2820) fdo#100094
> 
> fdo#100561 https://bugs.freedesktop.org/show_bug.cgi?id=100561
> fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
> fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
> fdo#100415 https://bugs.freedesktop.org/show_bug.cgi?id=100415
> fdo#100094 https://bugs.freedesktop.org/show_bug.cgi?id=100094
> 
> fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time: 434s
> fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time: 426s
> fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time: 576s
> fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time: 514s
> fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time: 547s
> fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time: 485s
> fi-byt-n2820     total:278  pass:248  dwarn:0   dfail:0   fail:2   skip:28  time: 491s
> fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 411s
> fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time: 405s
> fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time: 422s
> fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 490s
> fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 488s
> fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time: 459s
> fi-kbl-7560u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 564s
> fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 453s
> fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time: 575s
> fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time: 454s
> fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time: 490s
> fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time: 431s
> fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time: 526s
> fi-snb-2600      total:278  pass:248  dwarn:0   dfail:0   fail:1   skip:29  time: 403s
> 
> 5467cb1fdc74248d650217938305b8f51a0af3f8 drm-tip: 2017y-04m-04d-16h-54m-17s UTC integration manifest
> d6807fd5 drm/i915: Enable atomic on VLV/CHV
> 7e86af5 drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well
> d300717 drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4398/

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2017-04-05 10:30 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-03 15:19 [PATCH 0/4] drm/i915: Enable atomic for VLV/CHV ville.syrjala
2017-03-03 15:19 ` [PATCH 1/4] drm/i915: Extract intel_wm_plane_visible() ville.syrjala
2017-03-17 19:52   ` Chris Wilson
2017-03-03 15:19 ` [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR ville.syrjala
2017-03-17 19:54   ` Chris Wilson
2017-03-17 20:01     ` Ville Syrjälä
2017-03-17 19:56   ` Chris Wilson
2017-03-03 15:19 ` [PATCH 3/4] drm/i915: Use intel_wm_plane_visible() on VLV/CHV as well ville.syrjala
2017-03-17 19:55   ` Chris Wilson
2017-03-03 15:19 ` [PATCH 4/4] drm/i915: Enable atomic on VLV/CHV ville.syrjala
2017-03-06  7:05   ` Maarten Lankhorst
2017-03-03 16:47 ` ✗ Fi.CI.BAT: failure for drm/i915: Enable atomic for VLV/CHV Patchwork
2017-03-03 19:17   ` Ville Syrjälä
2017-03-06 15:48 ` Patchwork
2017-03-15 17:29 ` Patchwork
2017-03-20 19:00 ` Patchwork
2017-03-21 14:31 ` Patchwork
2017-04-04 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
2017-04-05 10:30   ` Ville Syrjälä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.