From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756614AbdCUHeu (ORCPT ); Tue, 21 Mar 2017 03:34:50 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36202 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669AbdCUHeW (ORCPT ); Tue, 21 Mar 2017 03:34:22 -0400 Date: Tue, 21 Mar 2017 08:27:00 +0100 From: Daniel Vetter To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] drm: Clarify the role of plane_state argument to drm_simple update(). Message-ID: <20170321072700.l3tjviffdq3abovb@phenom.ffwll.local> Mail-Followup-To: Eric Anholt , dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, Russell King , linux-kernel@vger.kernel.org References: <20170320233615.5242-1-eric@anholt.net> <20170320233615.5242-3-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170320233615.5242-3-eric@anholt.net> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2017 at 04:36:15PM -0700, Eric Anholt wrote: > Like the atomic update hook it's wrapping, the plane_state is the old > one, and the new one is in plane->state. Both msxfb and tinydrm use > it correctly, but I mistook it for the new state in pl111 due to its > naming. > > Signed-off-by: Eric Anholt We could do the same rename in mxsfb, and maybe extend the kernel-doc a bit more to document the parameters. But this is a good change already, so Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_simple_kms_helper.c | 4 ++-- > include/drm/drm_simple_kms_helper.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c > index 16789faa9291..e084f9f8ca66 100644 > --- a/drivers/gpu/drm/drm_simple_kms_helper.c > +++ b/drivers/gpu/drm/drm_simple_kms_helper.c > @@ -114,7 +114,7 @@ static int drm_simple_kms_plane_atomic_check(struct drm_plane *plane, > } > > static void drm_simple_kms_plane_atomic_update(struct drm_plane *plane, > - struct drm_plane_state *pstate) > + struct drm_plane_state *old_pstate) > { > struct drm_simple_display_pipe *pipe; > > @@ -122,7 +122,7 @@ static void drm_simple_kms_plane_atomic_update(struct drm_plane *plane, > if (!pipe->funcs || !pipe->funcs->update) > return; > > - pipe->funcs->update(pipe, pstate); > + pipe->funcs->update(pipe, old_pstate); > } > > static int drm_simple_kms_plane_prepare_fb(struct drm_plane *plane, > diff --git a/include/drm/drm_simple_kms_helper.h b/include/drm/drm_simple_kms_helper.h > index fffbb95a0915..2d36538e4a17 100644 > --- a/include/drm/drm_simple_kms_helper.h > +++ b/include/drm/drm_simple_kms_helper.h > @@ -72,7 +72,7 @@ struct drm_simple_display_pipe_funcs { > * the hardware lacks vblank support entirely. > */ > void (*update)(struct drm_simple_display_pipe *pipe, > - struct drm_plane_state *plane_state); > + struct drm_plane_state *old_plane_state); > > /** > * @prepare_fb: > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 3/3] drm: Clarify the role of plane_state argument to drm_simple update(). Date: Tue, 21 Mar 2017 08:27:00 +0100 Message-ID: <20170321072700.l3tjviffdq3abovb@phenom.ffwll.local> References: <20170320233615.5242-1-eric@anholt.net> <20170320233615.5242-3-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1BC089E19 for ; Tue, 21 Mar 2017 07:27:05 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id u48so21254933wrc.1 for ; Tue, 21 Mar 2017 00:27:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170320233615.5242-3-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, Russell King , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXIgMjAsIDIwMTcgYXQgMDQ6MzY6MTVQTSAtMDcwMCwgRXJpYyBBbmhvbHQgd3Jv dGU6Cj4gTGlrZSB0aGUgYXRvbWljIHVwZGF0ZSBob29rIGl0J3Mgd3JhcHBpbmcsIHRoZSBwbGFu ZV9zdGF0ZSBpcyB0aGUgb2xkCj4gb25lLCBhbmQgdGhlIG5ldyBvbmUgaXMgaW4gcGxhbmUtPnN0 YXRlLiAgQm90aCBtc3hmYiBhbmQgdGlueWRybSB1c2UKPiBpdCBjb3JyZWN0bHksIGJ1dCBJIG1p c3Rvb2sgaXQgZm9yIHRoZSBuZXcgc3RhdGUgaW4gcGwxMTEgZHVlIHRvIGl0cwo+IG5hbWluZy4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0PgoKV2UgY291 bGQgZG8gdGhlIHNhbWUgcmVuYW1lIGluIG14c2ZiLCBhbmQgbWF5YmUgZXh0ZW5kIHRoZSBrZXJu ZWwtZG9jIGEKYml0IG1vcmUgdG8gZG9jdW1lbnQgdGhlIHBhcmFtZXRlcnMuIEJ1dCB0aGlzIGlz IGEgZ29vZCBjaGFuZ2UgYWxyZWFkeSwgc28KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBs ZV9rbXNfaGVscGVyLmMgfCA0ICsrLS0KPiAgaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVs cGVyLmggICAgIHwgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVf a21zX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4g aW5kZXggMTY3ODlmYWE5MjkxLi5lMDg0ZjlmOGNhNjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9zaW1wbGVfa21zX2hlbHBlci5jCj4gQEAgLTExNCw3ICsxMTQsNyBAQCBzdGF0aWMgaW50IGRy bV9zaW1wbGVfa21zX3BsYW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwK PiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZHJtX3NpbXBsZV9rbXNfcGxhbmVfYXRvbWljX3VwZGF0 ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAtCQkJCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRl ICpwc3RhdGUpCj4gKwkJCQkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3BzdGF0ZSkKPiAg ewo+ICAJc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlOwo+ICAKPiBAQCAtMTIy LDcgKzEyMiw3IEBAIHN0YXRpYyB2b2lkIGRybV9zaW1wbGVfa21zX3BsYW5lX2F0b21pY191cGRh dGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlpZiAoIXBpcGUtPmZ1bmNzIHx8ICFwaXBl LT5mdW5jcy0+dXBkYXRlKQo+ICAJCXJldHVybjsKPiAgCj4gLQlwaXBlLT5mdW5jcy0+dXBkYXRl KHBpcGUsIHBzdGF0ZSk7Cj4gKwlwaXBlLT5mdW5jcy0+dXBkYXRlKHBpcGUsIG9sZF9wc3RhdGUp Owo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGRybV9zaW1wbGVfa21zX3BsYW5lX3ByZXBhcmVfZmIo c3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9z aW1wbGVfa21zX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmgK PiBpbmRleCBmZmZiYjk1YTA5MTUuLjJkMzY1MzhlNGExNyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRl L2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9zaW1w bGVfa21zX2hlbHBlci5oCj4gQEAgLTcyLDcgKzcyLDcgQEAgc3RydWN0IGRybV9zaW1wbGVfZGlz cGxheV9waXBlX2Z1bmNzIHsKPiAgCSAqIHRoZSBoYXJkd2FyZSBsYWNrcyB2Ymxhbmsgc3VwcG9y dCBlbnRpcmVseS4KPiAgCSAqLwo+ICAJdm9pZCAoKnVwZGF0ZSkoc3RydWN0IGRybV9zaW1wbGVf ZGlzcGxheV9waXBlICpwaXBlLAo+IC0JCSAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpw bGFuZV9zdGF0ZSk7Cj4gKwkJICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9wbGFu ZV9zdGF0ZSk7Cj4gIAo+ICAJLyoqCj4gIAkgKiBAcHJlcGFyZV9mYjoKPiAtLSAKPiAyLjExLjAK PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK