All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 0/4] staging: rtl8712: Invert if statements to reduce indentation level
Date: Tue, 21 Mar 2017 08:44:24 +0100	[thread overview]
Message-ID: <20170321074424.GA1816@kroah.com> (raw)
In-Reply-To: <cover.1489861352.git.narcisaanamaria12@gmail.com>

On Sat, Mar 18, 2017 at 08:33:58PM +0200, Narcisa Ana Maria Vasile wrote:
> This patchset reduces indentation level by inverting if statements,
> in order to clear out the error handling code immediately, and then
> continue executing the function without the excessive indentation and
> additional else branches.
> 
> These pieces of code where indentation was improved
> were found using Coccinelle.
> 
> ---
> Changes in v2:
>   - Make the commit messages more clear
>   - Improve layout of the functions
> 
> Narcisa Ana Maria Vasile (4):
>   staging: rtl8712: Invert if statements to reduce indentation level
>   staging: rtl8712: Invert if statement reduce indentation level
>   staging: rtl8712: Invert if statements to reduce indentation level
>   staging: rtl8712: Invert if statement to reduce indentation level

These are 4 patches, that all do different things, yet the subject line
is pretty much identical.  Please fix it up to be more unique.

thanks,

greg k-h


  parent reply	other threads:[~2017-03-21  7:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 15:58 [PATCH 0/4] staging: rtl8712: Refactor conditionals Narcisa Ana Maria Vasile
2017-03-10 15:59 ` [PATCH 1/4] staging: rtl8712: Refactor conditionals in wpa_set_encryption Narcisa Ana Maria Vasile
2017-03-10 18:21   ` [Outreachy kernel] " Julia Lawall
2017-03-10 15:59 ` [PATCH 2/4] staging: rtl8712: Refactor conditional in r8711_wx_get_freq Narcisa Ana Maria Vasile
2017-03-10 18:19   ` [Outreachy kernel] " Julia Lawall
2017-03-10 15:59 ` [PATCH 3/4] staging: rtl8712: Refactor conditionals in r8711_wx_get_rate Narcisa Ana Maria Vasile
2017-03-10 18:15   ` [Outreachy kernel] " Julia Lawall
2017-03-10 16:00 ` [PATCH 4/4] staging: rtl8712: Refactor conditional in r871x_get_ap_info Narcisa Ana Maria Vasile
2017-03-10 18:08   ` [Outreachy kernel] " Julia Lawall
2017-03-10 20:37     ` Narcisa Ana Maria Vasile
2017-03-10 20:41       ` Julia Lawall
2017-03-10 18:22 ` [Outreachy kernel] [PATCH 0/4] staging: rtl8712: Refactor conditionals Julia Lawall
2017-03-18 18:33 ` [PATCH v2 0/4] staging: rtl8712: Invert if statements to reduce indentation level Narcisa Ana Maria Vasile
2017-03-18 18:34   ` [PATCH v2 1/4] " Narcisa Ana Maria Vasile
2017-03-18 18:35   ` [PATCH v2 2/4] staging: rtl8712: Invert if statement " Narcisa Ana Maria Vasile
2017-03-18 18:35   ` [PATCH v2 3/4] staging: rtl8712: Invert if statements to " Narcisa Ana Maria Vasile
2017-03-18 18:35   ` [PATCH v2 4/4] staging: rtl8712: Invert if statement " Narcisa Ana Maria Vasile
2017-03-21  7:44   ` Greg KH [this message]
2017-03-21 22:52 ` [PATCH v3 0/4] staging: rtl8712: Refactor conditionals to reduce indentation Narcisa Ana Maria Vasile
2017-03-21 22:52   ` [PATCH v3 1/4] staging: rtl8712: Invert if statements to reduce indentation level Narcisa Ana Maria Vasile
2017-03-21 22:52   ` [PATCH v3 2/4] staging: rtl8712: Invert the test on check_fwstate() to reduce indentation Narcisa Ana Maria Vasile
2017-03-21 22:53   ` [PATCH v3 3/4] staging: rtl8712: Restructure code for clarity Narcisa Ana Maria Vasile
2017-03-21 22:53   ` [PATCH v3 4/4] staging: rtl8712: Invert comparison to reduce indentation Narcisa Ana Maria Vasile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321074424.GA1816@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=narcisaanamaria12@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.