All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check
Date: Tue, 21 Mar 2017 12:13:12 +0100	[thread overview]
Message-ID: <20170321111312.GB30407@ulmo.ba.sec> (raw)
In-Reply-To: <20170321102704.gmppuklsifvac5nj@phenom.ffwll.local>


[-- Attachment #1.1: Type: text/plain, Size: 746 bytes --]

On Tue, Mar 21, 2017 at 11:27:04AM +0100, Daniel Vetter wrote:
> On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > The expression &private->fbdev_helper can never be NULL, so the check is
> > completely unnecessary.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> On the 3 drivers patches (all except exynos):
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> For merging, do you want to push it all through drm-misc? Or planning on
> sending a pull request to Dave?

I think this is perfect material for drm-misc. I'll resend v4 shortly
with a build fix and the fix Andrzej pointed out folded into the Exynos
driver.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-03-21 11:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  8:13 [PATCH v3 00/10] drm/fb-helper: Deferred setup support Thierry Reding
2017-03-21  8:13 ` [PATCH v3 01/10] drm/fb-helper: Cleanup checkpatch warnings Thierry Reding
2017-03-21  9:36   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 02/10] drm/fb-helper: Reshuffle code for subsequent patches Thierry Reding
2017-03-21  9:36   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 03/10] drm/fb-helper: Improve code readability Thierry Reding
2017-03-21  9:37   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 04/10] drm/fb-helper: Push down modeset lock into FB helpers Thierry Reding
2017-03-21  9:38   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 05/10] drm/fb-helper: Add top-level lock Thierry Reding
2017-03-21 10:00   ` Daniel Vetter
2017-03-21 10:15     ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 06/10] drm/fb-helper: Support deferred setup Thierry Reding
2017-03-21 10:10   ` Daniel Vetter
2017-03-22 21:06     ` Thierry Reding
2017-03-22 21:08       ` Daniel Vetter
2017-04-03  8:48   ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 07/10] drm/exynos: Remove custom FB helper " Thierry Reding
2017-03-21  9:58   ` Andrzej Hajda
2017-03-21 10:20     ` Daniel Vetter
2017-03-21 10:42       ` Andrzej Hajda
2017-03-21 10:53         ` Thierry Reding
2017-03-21 11:13           ` Andrzej Hajda
2017-03-21 11:17             ` Thierry Reding
2017-03-21 12:28             ` Daniel Vetter
2017-03-21  8:13 ` [PATCH v3 08/10] drm/hisilicon: " Thierry Reding
2017-03-21  8:13 ` [PATCH v3 09/10] drm/atmel-hlcdc: Remove unnecessary NULL check Thierry Reding
2017-03-21  8:13 ` [PATCH v3 10/10] drm/rockchip: " Thierry Reding
2017-03-21 10:27   ` Daniel Vetter
2017-03-21 11:13     ` Thierry Reding [this message]
2017-03-21  9:57 ` ✓ Fi.CI.BAT: success for drm/fb-helper: Deferred setup support (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321111312.GB30407@ulmo.ba.sec \
    --to=thierry.reding@gmail.com \
    --cc=daniel.vetter@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.