From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933329AbdCUUTX (ORCPT ); Tue, 21 Mar 2017 16:19:23 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38086 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932511AbdCUUTW (ORCPT ); Tue, 21 Mar 2017 16:19:22 -0400 Date: Tue, 21 Mar 2017 23:19:04 +0300 From: Dan Carpenter To: Perry Hooker Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, aditya.shankar@microchip.com, linux-kernel@vger.kernel.org, ganesh.krishna@microchip.com Subject: Re: [PATCH] staging: wilc1000: use kernel define byte order macros Message-ID: <20170321201904.GD32449@mwanda> References: <1490126140-12867-1-git-send-email-perry.hooker@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490126140-12867-1-git-send-email-perry.hooker@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 01:55:40PM -0600, Perry Hooker wrote: > This commit fixes the following sparse warnings: > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1473:45: warning: incorrect type in argument 1 (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2011:52: warning: incorrect type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2012:51: warning: incorrect type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2078:51: warning: incorrect type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2083:52: warning: incorrect type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2084:51: warning: incorrect type in assignment (different base types) > > Signed-off-by: Perry Hooker > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > index a37896f..d1c75c7 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > @@ -1470,7 +1470,7 @@ void WILC_WFI_p2p_rx(struct net_device *dev, u8 *buff, u32 size) > } else { > s32Freq = ieee80211_channel_to_frequency(curr_channel, NL80211_BAND_2GHZ); > > - if (ieee80211_is_action(buff[FRAME_TYPE_ID])) { > + if (ieee80211_is_action(cpu_to_le16(buff[FRAME_TYPE_ID]))) { Nah... You're just introducing bugs here. Please be more careful. regards, dan carpenter