From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759440AbdCVMg5 (ORCPT ); Wed, 22 Mar 2017 08:36:57 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:35018 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdCVMgt (ORCPT ); Wed, 22 Mar 2017 08:36:49 -0400 Date: Wed, 22 Mar 2017 13:36:41 +0100 From: Ralf Baechle To: Amit Kama IL Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mips@linux-mips.org" , "tglx@linutronix.de" , "jason@lakedaemon.net" , "marc.zyngier@arm.com" , "linux-doc@vger.kernel.org" , "corbet@lwn.net" Subject: Re: [PATCH] Add initial SX3000b platform code to MIPS arch Message-ID: <20170322123641.GN14919@linux-mips.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 05:38:09AM +0000, Amit Kama IL wrote: > Add initial support for boards based on Satixfy's SX3000b (Catniss) SoC. > The SoC includes a MIPS interAptiv dual core 4 VPE processor and boots > using device-tree. > > Signed-off-by: Amit Kama > > The irqchip file (irq-sx3000b.c) is pertinent to the platform. > IRQCHIP maintainers - is it possible to merge this through MIPS tree? First thig, run your patch through scripts/checkpatch.pl and fix the resulting pile of errors and warnings. sx3000_machine_halt() will consume plenty of power if implemented as a empty loop: +static void sx3000_machine_halt(void) +{ + while (true); +} Something like: static void sx3000_machine_halt(void) { local_irq_disable(); while (1) { if (cpu_wait) cpu_wait(); } } will make the function much "greener". Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH] Add initial SX3000b platform code to MIPS arch Date: Wed, 22 Mar 2017 13:36:41 +0100 Message-ID: <20170322123641.GN14919@linux-mips.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Amit Kama IL Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org" , "tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org" , "jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org" , "marc.zyngier-5wv7dgnIgG8@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "corbet-T1hC0tSOHrs@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Mar 22, 2017 at 05:38:09AM +0000, Amit Kama IL wrote: > Add initial support for boards based on Satixfy's SX3000b (Catniss) SoC. > The SoC includes a MIPS interAptiv dual core 4 VPE processor and boots > using device-tree. > > Signed-off-by: Amit Kama > > The irqchip file (irq-sx3000b.c) is pertinent to the platform. > IRQCHIP maintainers - is it possible to merge this through MIPS tree? First thig, run your patch through scripts/checkpatch.pl and fix the resulting pile of errors and warnings. sx3000_machine_halt() will consume plenty of power if implemented as a empty loop: +static void sx3000_machine_halt(void) +{ + while (true); +} Something like: static void sx3000_machine_halt(void) { local_irq_disable(); while (1) { if (cpu_wait) cpu_wait(); } } will make the function much "greener". Ralf -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html