* [PATCH 3/3] mm: fix a coding style issue
@ 2017-03-23 7:49 ` Kristaps Civkulis
0 siblings, 0 replies; 6+ messages in thread
From: Kristaps Civkulis @ 2017-03-23 7:49 UTC (permalink / raw)
To: akpm; +Cc: mhocko, mike.kravetz, linux-mm, linux-kernel, Kristaps Civkulis
Fix a coding style issue.
Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
---
mm/hugetlb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3d0aab9ee80d..4c72c1974c8c 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
return 0;
else
return 1;
- }
- else
+ } else
return ret < 0 ? ret : 0;
}
--
2.12.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] mm: fix a coding style issue
@ 2017-03-23 7:49 ` Kristaps Civkulis
0 siblings, 0 replies; 6+ messages in thread
From: Kristaps Civkulis @ 2017-03-23 7:49 UTC (permalink / raw)
To: akpm; +Cc: mhocko, mike.kravetz, linux-mm, linux-kernel, Kristaps Civkulis
Fix a coding style issue.
Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
---
mm/hugetlb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3d0aab9ee80d..4c72c1974c8c 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
return 0;
else
return 1;
- }
- else
+ } else
return ret < 0 ? ret : 0;
}
--
2.12.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mm: fix a coding style issue
2017-03-23 7:49 ` Kristaps Civkulis
@ 2017-03-23 8:12 ` Kristaps Civkulis
-1 siblings, 0 replies; 6+ messages in thread
From: Kristaps Civkulis @ 2017-03-23 8:12 UTC (permalink / raw)
To: akpm; +Cc: mhocko, mike.kravetz, linux-mm, linux-kernel
Fix a coding style issue.
Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
---
Resend, because it should be only [PATCH] in subject.
---
mm/hugetlb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3d0aab9ee80d..4c72c1974c8c 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
return 0;
else
return 1;
- }
- else
+ } else
return ret < 0 ? ret : 0;
}
--
2.12.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mm: fix a coding style issue
@ 2017-03-23 8:12 ` Kristaps Civkulis
0 siblings, 0 replies; 6+ messages in thread
From: Kristaps Civkulis @ 2017-03-23 8:12 UTC (permalink / raw)
To: akpm; +Cc: mhocko, mike.kravetz, linux-mm, linux-kernel
Fix a coding style issue.
Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
---
Resend, because it should be only [PATCH] in subject.
---
mm/hugetlb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3d0aab9ee80d..4c72c1974c8c 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
return 0;
else
return 1;
- }
- else
+ } else
return ret < 0 ? ret : 0;
}
--
2.12.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: fix a coding style issue
2017-03-23 8:12 ` Kristaps Civkulis
@ 2017-03-24 7:22 ` Michal Hocko
-1 siblings, 0 replies; 6+ messages in thread
From: Michal Hocko @ 2017-03-24 7:22 UTC (permalink / raw)
To: Kristaps Civkulis; +Cc: akpm, mike.kravetz, linux-mm, linux-kernel
On Thu 23-03-17 10:12:44, Kristaps Civkulis wrote:
> Fix a coding style issue.
I believe style fixes are worth applying only when part of a larger
change which does something useful or where the resulting code is much
easier to read. This doesn't seem to be the case here.
> Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
> ---
> Resend, because it should be only [PATCH] in subject.
> ---
> mm/hugetlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 3d0aab9ee80d..4c72c1974c8c 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
> return 0;
> else
> return 1;
> - }
> - else
> + } else
> return ret < 0 ? ret : 0;
> }
>
> --
> 2.12.0
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: fix a coding style issue
@ 2017-03-24 7:22 ` Michal Hocko
0 siblings, 0 replies; 6+ messages in thread
From: Michal Hocko @ 2017-03-24 7:22 UTC (permalink / raw)
To: Kristaps Civkulis; +Cc: akpm, mike.kravetz, linux-mm, linux-kernel
On Thu 23-03-17 10:12:44, Kristaps Civkulis wrote:
> Fix a coding style issue.
I believe style fixes are worth applying only when part of a larger
change which does something useful or where the resulting code is much
easier to read. This doesn't seem to be the case here.
> Signed-off-by: Kristaps Civkulis <kristaps.civkulis@gmail.com>
> ---
> Resend, because it should be only [PATCH] in subject.
> ---
> mm/hugetlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 3d0aab9ee80d..4c72c1974c8c 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1916,8 +1916,7 @@ static long __vma_reservation_common(struct hstate *h,
> return 0;
> else
> return 1;
> - }
> - else
> + } else
> return ret < 0 ? ret : 0;
> }
>
> --
> 2.12.0
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-24 7:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-23 7:49 [PATCH 3/3] mm: fix a coding style issue Kristaps Civkulis
2017-03-23 7:49 ` Kristaps Civkulis
2017-03-23 8:12 ` [PATCH] " Kristaps Civkulis
2017-03-23 8:12 ` Kristaps Civkulis
2017-03-24 7:22 ` Michal Hocko
2017-03-24 7:22 ` Michal Hocko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.