From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 02/17] app/test: eventdev link all queues
	before start
Date: Thu, 23 Mar 2017 15:48:43 +0530
Message-ID: <20170323101842.dkaggt532l4grbis@localhost.localdomain>
References: <1487343252-16092-1-git-send-email-harry.van.haaren@intel.com>
 <1489175012-101439-1-git-send-email-harry.van.haaren@intel.com>
 <1489175012-101439-3-git-send-email-harry.van.haaren@intel.com>
 <20170320044604.3s6nznimvyv52ehr@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0059.outbound.protection.outlook.com [104.47.42.59])
 by dpdk.org (Postfix) with ESMTP id 89FD6695C
 for <dev@dpdk.org>; Thu, 23 Mar 2017 11:19:03 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20170320044604.3s6nznimvyv52ehr@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Mar 20, 2017 at 10:16:04AM +0530, Jerin Jacob wrote:
> On Fri, Mar 10, 2017 at 07:43:17PM +0000, Harry van Haaren wrote:
> > The software eventdev can lock-up if not all queues are
> > linked to a port. For this reason, the software evendev
> > fails to start if queues are not linked to anything.
> > 
> > This commit creates dummy links from all queues to port
> > 0 in the eventdev setup function and start/stop test,
> > which would otherwise fail due to unlinked queues.
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied to dpdk-next-eventdev/master. Thanks.

> 
> > ---
> >  app/test/test_eventdev.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> > index 042a446..324ef5a 100644
> > --- a/app/test/test_eventdev.c
> > +++ b/app/test/test_eventdev.c
> > @@ -543,6 +543,10 @@ test_eventdev_start_stop(void)
> >  		TEST_ASSERT_SUCCESS(ret, "Failed to setup port%d", i);
> >  	}
> >  
> > +	ret = rte_event_port_link(TEST_DEV_ID, 0, NULL, NULL, 0);
> > +	TEST_ASSERT(ret == rte_event_queue_count(TEST_DEV_ID),
> > +			"Failed to link port, device %d", TEST_DEV_ID);
> > +
> >  	ret = rte_event_dev_start(TEST_DEV_ID);
> >  	TEST_ASSERT_SUCCESS(ret, "Failed to start device%d", TEST_DEV_ID);
> >  
> > @@ -569,6 +573,10 @@ eventdev_setup_device(void)
> >  		TEST_ASSERT_SUCCESS(ret, "Failed to setup port%d", i);
> >  	}
> >  
> > +	ret = rte_event_port_link(TEST_DEV_ID, 0, NULL, NULL, 0);
> > +	TEST_ASSERT(ret == rte_event_queue_count(TEST_DEV_ID),
> > +			"Failed to link port, device %d", TEST_DEV_ID);
> > +
> >  	ret = rte_event_dev_start(TEST_DEV_ID);
> >  	TEST_ASSERT_SUCCESS(ret, "Failed to start device%d", TEST_DEV_ID);
> >  
> > -- 
> > 2.7.4
> >