From: Wei Liu <wei.liu2@citrix.com>
To: Luca Miccio <lucmiccio@gmail.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com,
xen-devel@lists.xenproject.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/Makefile: remove all temporary files for every architecture
Date: Thu, 23 Mar 2017 11:20:00 +0000 [thread overview]
Message-ID: <20170323111959.o2clurft2wrbgmch@citrix.com> (raw)
In-Reply-To: <20170323110704.coylbras6guq6tf6@citrix.com>
On Thu, Mar 23, 2017 at 11:07:04AM +0000, Wei Liu wrote:
> On Thu, Mar 23, 2017 at 02:31:37AM +0100, Luca Miccio wrote:
> > Execute the clean target for both arm and x86 architecture.
> >
> > When trying to build Xen for a different architecture in the same
> > tree, the command make clean will only remove temporary files for
> > the host architecture.
> > This will lead a compilation error when trying to build ARM64 and
> > ARM32 Xen in the same tree.
> > (See also: https://lists.xenproject.org/archives/html/xen-devel/2016-11/msg02176.html)
> >
> > Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
> > ---
> > xen/Makefile | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/Makefile b/xen/Makefile
> > index dc6862e04d..fcd5c7e9d6 100644
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -115,7 +115,8 @@ _clean: delete-unfresh-files
> > $(MAKE) -f $(BASEDIR)/Rules.mk -C drivers clean
> > $(MAKE) -f $(BASEDIR)/Rules.mk -C xsm clean
> > $(MAKE) -f $(BASEDIR)/Rules.mk -C crypto clean
> > - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) clean
> > + $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/arm clean
> > + $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/x86 clean
>
> A more future-proof way of doing this is to use find to collect a list
> of directory under arch/ and iterate.
>
> But I don't see a new architecture support coming any time soon, so
> this is just a suggestion.
>
Also, you seem to have missed overriding TARGET_ARCH and TARGET_SUBARCH.
I believe there are references to them in arch-specific Makefiles.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-23 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 1:31 [PATCH] xen/Makefile: remove all temporary files for every architecture Luca Miccio
2017-03-23 11:07 ` Wei Liu
2017-03-23 11:20 ` Wei Liu [this message]
2017-03-23 12:48 ` Luca Miccio
2017-03-23 12:52 ` Wei Liu
2017-03-24 11:49 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323111959.o2clurft2wrbgmch@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=lucmiccio@gmail.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.