From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-fbdev@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
boris.ostrovsky@oracle.com, stable@vger.kernel.org,
b.zolnierkie@samsung.com
Subject: [PATCH] xen, fbfront: fix connecting to backend
Date: Thu, 23 Mar 2017 13:52:52 +0100 [thread overview]
Message-ID: <20170323125252.11763-1-jgross__1748.12664413384$1490273632$gmane$org@suse.com> (raw)
Connecting to the backend isn't working reliably in xen-fbfront: in
case XenbusStateInitWait of the backend has been missed the backend
transition to XenbusStateConnected will trigger the connected state
only without doing the actions required when the backend has
connected.
Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/video/fbdev/xen-fbfront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index d0115a7..3ee309c 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
break;
case XenbusStateInitWait:
-InitWait:
xenbus_switch_state(dev, XenbusStateConnected);
break;
@@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
* get Connected twice here.
*/
if (dev->state != XenbusStateConnected)
- goto InitWait; /* no InitWait seen yet, fudge it */
+ /* no InitWait seen yet, fudge it */
+ xenbus_switch_state(dev, XenbusStateConnected);
if (xenbus_read_unsigned(info->xbdev->otherend,
"request-update", 0))
--
2.10.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-03-23 12:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 12:52 Juergen Gross [this message]
2017-03-23 12:52 [PATCH] xen, fbfront: fix connecting to backend Juergen Gross
2017-03-23 12:52 ` Juergen Gross
2017-03-23 13:37 ` Jan Beulich
[not found] ` <58D3DDB40200007800146C6B@suse.com>
2017-03-23 13:56 ` [Xen-devel] " Juergen Gross
2017-03-23 14:21 ` Jan Beulich
2017-03-23 13:56 ` Juergen Gross
2017-03-23 14:11 ` Boris Ostrovsky
2017-03-23 14:11 ` Boris Ostrovsky
2017-03-23 14:11 ` Boris Ostrovsky
2017-04-07 15:27 ` Bartlomiej Zolnierkiewicz
2017-04-07 15:27 ` Bartlomiej Zolnierkiewicz
2017-04-07 15:27 ` Bartlomiej Zolnierkiewicz
2017-04-05 8:18 ` Juergen Gross
2017-04-05 8:18 ` Juergen Gross
2017-04-05 8:18 ` Juergen Gross
2017-04-05 14:28 ` Bartlomiej Zolnierkiewicz
2017-04-05 14:28 ` Bartlomiej Zolnierkiewicz
2017-04-05 14:28 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20170323125252.11763-1-jgross__1748.12664413384$1490273632$gmane$org@suse.com' \
--to=jgross@suse.com \
--cc=b.zolnierkie@samsung.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.