All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH 18/51] ram: Move xbzrle_pages into RAMState
Date: Thu, 23 Mar 2017 21:45:11 +0100	[thread overview]
Message-ID: <20170323204544.12015-19-quintela@redhat.com> (raw)
In-Reply-To: <20170323204544.12015-1-quintela@redhat.com>

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/ram.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 721fd66..b4e647a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -174,6 +174,8 @@ struct RAMState {
     uint64_t iterations;
     /* xbzrle transmitted bytes */
     uint64_t xbzrle_bytes;
+    /* xbzrle transmmited pages */
+    uint64_t xbzrle_pages;
 };
 typedef struct RAMState RAMState;
 
@@ -181,7 +183,6 @@ static RAMState ram_state;
 
 /* accounting for migration statistics */
 typedef struct AccountingInfo {
-    uint64_t xbzrle_pages;
     uint64_t xbzrle_cache_miss;
     double xbzrle_cache_miss_rate;
     uint64_t xbzrle_overflows;
@@ -211,7 +212,7 @@ uint64_t xbzrle_mig_bytes_transferred(void)
 
 uint64_t xbzrle_mig_pages_transferred(void)
 {
-    return acct_info.xbzrle_pages;
+    return ram_state.xbzrle_pages;
 }
 
 uint64_t xbzrle_mig_pages_cache_miss(void)
@@ -544,7 +545,7 @@ static int save_xbzrle_page(RAMState *rs, QEMUFile *f, uint8_t **current_data,
     qemu_put_be16(f, encoded_len);
     qemu_put_buffer(f, XBZRLE.encoded_buf, encoded_len);
     bytes_xbzrle += encoded_len + 1 + 2;
-    acct_info.xbzrle_pages++;
+    rs->xbzrle_pages++;
     rs->xbzrle_bytes += bytes_xbzrle;
     *bytes_transferred += bytes_xbzrle;
 
@@ -1997,6 +1998,7 @@ static int ram_save_init_globals(RAMState *rs)
     rs->norm_pages = 0;
     rs->iterations = 0;
     rs->xbzrle_bytes = 0;
+    rs->xbzrle_pages = 0;
     migration_bitmap_sync_init(rs);
     qemu_mutex_init(&migration_bitmap_mutex);
 
-- 
2.9.3

  parent reply	other threads:[~2017-03-23 20:46 UTC|newest]

Thread overview: 167+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 20:44 [Qemu-devel] [PATCH v2 00/51] Creating RAMState for migration Juan Quintela
2017-03-23 20:44 ` [Qemu-devel] [PATCH 01/51] ram: Update all functions comments Juan Quintela
2017-03-24  9:55   ` Peter Xu
2017-03-24 11:44     ` Juan Quintela
2017-03-26 13:43       ` Peter Xu
2017-03-28 18:32         ` Juan Quintela
2017-03-31 14:43     ` Dr. David Alan Gilbert
2017-04-03 20:40       ` Juan Quintela
2017-03-31 15:51   ` Dr. David Alan Gilbert
2017-04-04 17:12     ` Juan Quintela
2017-03-23 20:44 ` [Qemu-devel] [PATCH 02/51] ram: rename block_name to rbname Juan Quintela
2017-03-24 11:11   ` Dr. David Alan Gilbert
2017-03-24 17:15   ` Eric Blake
2017-03-28 10:52     ` Juan Quintela
2017-03-23 20:44 ` [Qemu-devel] [PATCH 03/51] ram: Create RAMState Juan Quintela
2017-03-27  4:43   ` Peter Xu
2017-03-23 20:44 ` [Qemu-devel] [PATCH 04/51] ram: Add dirty_rate_high_cnt to RAMState Juan Quintela
2017-03-27  7:24   ` Peter Xu
2017-03-23 20:44 ` [Qemu-devel] [PATCH 05/51] ram: Move bitmap_sync_count into RAMState Juan Quintela
2017-03-27  7:34   ` Peter Xu
2017-03-28 10:56     ` Juan Quintela
2017-03-29  6:55       ` Peter Xu
2017-03-29  8:56         ` Juan Quintela
2017-03-29  9:07           ` Peter Xu
2017-03-23 20:44 ` [Qemu-devel] [PATCH 06/51] ram: Move start time " Juan Quintela
2017-03-27  7:54   ` Peter Xu
2017-03-28 11:00     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 07/51] ram: Move bytes_xfer_prev " Juan Quintela
2017-03-27  8:04   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 08/51] ram: Move num_dirty_pages_period " Juan Quintela
2017-03-27  8:07   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 09/51] ram: Move xbzrle_cache_miss_prev " Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 10/51] ram: Move iterations_prev " Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 11/51] ram: Move dup_pages " Juan Quintela
2017-03-27  9:23   ` Peter Xu
2017-03-28 18:43     ` Juan Quintela
2017-03-29  7:02       ` Peter Xu
2017-03-29  8:26         ` Juan Quintela
2017-03-31 14:58       ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 12/51] ram: Remove unused dup_mig_bytes_transferred() Juan Quintela
2017-03-27  9:24   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 13/51] ram: Remove unused pages_skipped variable Juan Quintela
2017-03-27  9:26   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 14/51] ram: Move norm_pages to RAMState Juan Quintela
2017-03-27  9:43   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 15/51] ram: Remove norm_mig_bytes_transferred Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 16/51] ram: Move iterations into RAMState Juan Quintela
2017-03-27 10:46   ` Peter Xu
2017-03-28 18:34     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 17/51] ram: Move xbzrle_bytes " Juan Quintela
2017-03-24 10:12   ` Dr. David Alan Gilbert
2017-03-27 10:48   ` Peter Xu
2017-03-23 20:45 ` Juan Quintela [this message]
2017-03-24 10:13   ` [Qemu-devel] [PATCH 18/51] ram: Move xbzrle_pages " Dr. David Alan Gilbert
2017-03-27 10:59   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 19/51] ram: Move xbzrle_cache_miss " Juan Quintela
2017-03-24 10:15   ` Dr. David Alan Gilbert
2017-03-27 11:00   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 20/51] ram: Move xbzrle_cache_miss_rate " Juan Quintela
2017-03-24 10:17   ` Dr. David Alan Gilbert
2017-03-27 11:01   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 21/51] ram: Move xbzrle_overflows " Juan Quintela
2017-03-24 10:22   ` Dr. David Alan Gilbert
2017-03-27 11:03   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 22/51] ram: Move migration_dirty_pages to RAMState Juan Quintela
2017-03-30  6:24   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 23/51] ram: Everything was init to zero, so use memset Juan Quintela
2017-03-29 17:14   ` Dr. David Alan Gilbert
2017-03-30  6:25   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 24/51] ram: Move migration_bitmap_mutex into RAMState Juan Quintela
2017-03-30  6:25   ` Peter Xu
2017-03-30  8:49   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 25/51] ram: Move migration_bitmap_rcu " Juan Quintela
2017-03-30  6:25   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 26/51] ram: Move bytes_transferred " Juan Quintela
2017-03-29 17:38   ` Dr. David Alan Gilbert
2017-03-30  6:26   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 27/51] ram: Use the RAMState bytes_transferred parameter Juan Quintela
2017-03-30  6:27   ` Peter Xu
2017-03-30 16:05     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 28/51] ram: Remove ram_save_remaining Juan Quintela
2017-03-24 15:34   ` Dr. David Alan Gilbert
2017-03-30  6:24   ` Peter Xu
2017-03-30 16:07     ` Juan Quintela
2017-03-31  2:57       ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 29/51] ram: Move last_req_rb to RAMState Juan Quintela
2017-03-30  6:49   ` Peter Xu
2017-03-30 16:08     ` Juan Quintela
2017-03-31  3:00       ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 30/51] ram: Move src_page_req* " Juan Quintela
2017-03-30  6:56   ` Peter Xu
2017-03-30 16:09     ` Juan Quintela
2017-03-31 15:25     ` Dr. David Alan Gilbert
2017-04-01  7:15       ` Peter Xu
2017-04-05 10:27         ` Dr. David Alan Gilbert
2017-03-31 16:52   ` Dr. David Alan Gilbert
2017-04-04 17:42     ` Juan Quintela
2017-04-05 10:34       ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 31/51] ram: Create ram_dirty_sync_count() Juan Quintela
2017-03-29  9:06   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 32/51] ram: Remove dirty_bytes_rate Juan Quintela
2017-03-30  7:00   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 33/51] ram: Move dirty_pages_rate to RAMState Juan Quintela
2017-03-30  7:04   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 34/51] ram: Move postcopy_requests into RAMState Juan Quintela
2017-03-30  7:06   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 35/51] ram: Add QEMUFile to RAMState Juan Quintela
2017-03-24 10:52   ` Dr. David Alan Gilbert
2017-03-24 11:14     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 36/51] ram: Move QEMUFile into RAMState Juan Quintela
2017-03-31 14:21   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 37/51] ram: Move compression_switch to RAMState Juan Quintela
2017-03-29 18:02   ` Dr. David Alan Gilbert
2017-03-30 16:19     ` Juan Quintela
2017-03-30 16:27     ` Juan Quintela
2017-03-30  7:52   ` Peter Xu
2017-03-30 16:30     ` Juan Quintela
2017-03-31  3:04       ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 38/51] migration: Remove MigrationState from migration_in_postcopy Juan Quintela
2017-03-24 15:27   ` Dr. David Alan Gilbert
2017-03-30  8:06   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 39/51] ram: We don't need MigrationState parameter anymore Juan Quintela
2017-03-24 15:28   ` Dr. David Alan Gilbert
2017-03-30  8:05   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 40/51] ram: Rename qemu_target_page_bits() to qemu_target_page_size() Juan Quintela
2017-03-24 15:32   ` Dr. David Alan Gilbert
2017-03-30  8:03   ` Peter Xu
2017-03-30  8:55     ` Dr. David Alan Gilbert
2017-03-30  9:11     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 41/51] Add page-size to output in 'info migrate' Juan Quintela
2017-03-24 17:17   ` Eric Blake
2017-03-23 20:45 ` [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync Juan Quintela
2017-03-24  1:10   ` Yang Hongyang
2017-03-24  8:29     ` Juan Quintela
2017-03-24  9:11       ` Yang Hongyang
2017-03-24 10:05         ` Juan Quintela
2017-03-28 17:12       ` Dr. David Alan Gilbert
2017-03-28 18:45         ` Juan Quintela
2017-03-30  9:07   ` Dr. David Alan Gilbert
2017-03-30 11:38     ` Juan Quintela
2017-03-30 19:10       ` Dr. David Alan Gilbert
2017-04-04 17:46         ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 43/51] ram: ram_discard_range() don't use the mis parameter Juan Quintela
2017-03-29 18:43   ` Dr. David Alan Gilbert
2017-03-30 10:28   ` Peter Xu
2017-03-23 20:45 ` [Qemu-devel] [PATCH 44/51] ram: reorganize last_sent_block Juan Quintela
2017-03-31  8:35   ` Peter Xu
2017-03-31  8:40   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 45/51] ram: Use page number instead of an address for the bitmap operations Juan Quintela
2017-03-31 12:22   ` Dr. David Alan Gilbert
2017-04-04 18:21     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 46/51] ram: Remember last_page instead of last_offset Juan Quintela
2017-03-31  9:09   ` Dr. David Alan Gilbert
2017-04-04 18:24     ` Juan Quintela
2017-03-23 20:45 ` [Qemu-devel] [PATCH 47/51] ram: Change offset field in PageSearchStatus to page Juan Quintela
2017-03-31 12:31   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 48/51] ram: Use ramblock and page offset instead of absolute offset Juan Quintela
2017-03-31 17:17   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 49/51] ram: rename last_ram_offset() last_ram_pages() Juan Quintela
2017-03-31 14:23   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 50/51] ram: Use RAMBitmap type for coherence Juan Quintela
2017-03-31 14:27   ` Dr. David Alan Gilbert
2017-03-23 20:45 ` [Qemu-devel] [PATCH 51/51] migration: Remove MigrationState parameter from migration_is_idle() Juan Quintela
2017-03-24 16:38   ` Dr. David Alan Gilbert
2017-03-31 14:34 ` [Qemu-devel] [PATCH v2 00/51] Creating RAMState for migration Dr. David Alan Gilbert
2017-04-04 17:22   ` Juan Quintela
2017-04-04 17:36     ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170323204544.12015-19-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.