All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Joao.Pinto@synopsys.com
Cc: clabbe.montjoie@gmail.com, thierry.reding@gmail.com,
	peppe.cavallaro@st.com, alexandre.torgue@st.com,
	f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers
Date: Fri, 24 Mar 2017 10:17:34 -0700 (PDT)	[thread overview]
Message-ID: <20170324.101734.2195203757001166516.davem@davemloft.net> (raw)
In-Reply-To: <748685e5-86f8-5f6b-66db-04ec96af4bd6@synopsys.com>

From: Joao Pinto <Joao.Pinto@synopsys.com>
Date: Fri, 24 Mar 2017 15:02:27 +0000

> Yes, I agree, it is better to revert and leave the tree functional for all.
> 
> @David Miller:
> The multiple-buffer patch introduced some problems in some setups that are being
> hard to debug, so Corentin gave the idea of reverting the until
> commit 7bac4e1ec3ca2342929a39638d615c6b672c27a0 (net: stmmac: stmmac interrupt
> treatment prepared for multiple queues), which I fully agree.
> 
> In my setup is ok, but the idea is to have everyone's setup working :), so lets
> break them into smaller pieces, and let's only apply them when everyone confirms
> that is working ok in your setups, agree?
> 
> What is the typical mechanism for this? I send a patch reverting them?

If you can compose a single "git revert" command to achieve this, just
tell me what it is and I'll do it.

Otherwise send a patch that does the revert.

Thanks.

  reply	other threads:[~2017-03-24 17:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 16:11 [PATCH v2 net-next 0/3] net: stmmac: adding multiple buffers and routing Joao Pinto
2017-03-17 16:11 ` [PATCH v2 net-next 1/3] net: stmmac: enable multiple buffers Joao Pinto
2017-03-23 17:17   ` [v2,net-next,1/3] " Thierry Reding
2017-03-23 17:27     ` Joao Pinto
2017-03-23 18:10       ` Thierry Reding
2017-03-24 14:09         ` Corentin Labbe
2017-03-24 14:59           ` Joao Pinto
2017-03-24 15:02             ` Fwd: " Joao Pinto
2017-03-24 17:17               ` David Miller [this message]
2017-03-24 17:19                 ` Joao Pinto
2017-03-24  7:42       ` Andrew Lunn
2017-03-24 10:47         ` Joao Pinto
2017-03-24 11:17           ` Andrew Lunn
2017-03-24 11:21             ` Joao Pinto
2017-03-24 17:05             ` David Miller
2017-03-24 17:09               ` Joao Pinto
2017-03-27  9:28                 ` Alexandre Torgue
2017-03-27  9:34                   ` Joao Pinto
2017-03-17 16:11 ` [PATCH v2 net-next 2/3] net: stmmac: TX and RX queue priority configuration Joao Pinto
2017-03-17 16:11 ` [PATCH v2 net-next 3/3] net: stmmac: RX queue routing configuration Joao Pinto
2017-03-22  0:24 ` [PATCH v2 net-next 0/3] net: stmmac: adding multiple buffers and routing David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324.101734.2195203757001166516.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Joao.Pinto@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.