From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] arm64: dts: ls1012a: add crypto node Date: Fri, 24 Mar 2017 15:34:23 +0800 Message-ID: <20170324073420.GM30608@dragon> References: <20170322122939.22117-1-horia.geanta@nxp.com> <20170324015606.GC30608@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Mark Rutland , "devicetree@vger.kernel.org" , Herbert Xu , Harninder Rai , Catalin Marinas , Bhaskar U , Will Deacon , Dan Douglass , Rob Herring , "linux-crypto@vger.kernel.org" , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" To: Horia =?utf-8?Q?Geant=C4=83?= Return-path: Received: from mail.kernel.org ([198.145.29.136]:55904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbdCXHfE (ORCPT ); Fri, 24 Mar 2017 03:35:04 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Mar 24, 2017 at 07:17:50AM +0000, Horia Geantă wrote: > >> + sec_mon: sec_mon@1e90000 { > > > > Hyphen is more preferred to be used in node name than underscore. > > > This would imply changing the > Documentation/devicetree/bindings/crypto/fsl-sec4.txt binding and > dealing with all the consequences, which IIUC is probably not worth. I do not care the bindings doc that much, since I'm not the maintainer of it. What are the consequences specifically, if we use a better node name in dts than bindings example? Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Fri, 24 Mar 2017 15:34:23 +0800 Subject: [PATCH] arm64: dts: ls1012a: add crypto node In-Reply-To: References: <20170322122939.22117-1-horia.geanta@nxp.com> <20170324015606.GC30608@dragon> Message-ID: <20170324073420.GM30608@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 24, 2017 at 07:17:50AM +0000, Horia Geant? wrote: > >> + sec_mon: sec_mon at 1e90000 { > > > > Hyphen is more preferred to be used in node name than underscore. > > > This would imply changing the > Documentation/devicetree/bindings/crypto/fsl-sec4.txt binding and > dealing with all the consequences, which IIUC is probably not worth. I do not care the bindings doc that much, since I'm not the maintainer of it. What are the consequences specifically, if we use a better node name in dts than bindings example? Shawn