From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [i-g-t PATCH 2/2] igt/kms_flip: Fix set_dpms called with an idle bo
Date: Fri, 24 Mar 2017 12:11:41 +0000 [thread overview]
Message-ID: <20170324121141.GE9495@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1490356500.4193.1.camel@gmail.com>
On Fri, Mar 24, 2017 at 01:55:00PM +0200, Ander Conselvan De Oliveira wrote:
> On Thu, 2016-12-01 at 11:23 +0000, Chris Wilson wrote:
> > On Thu, Dec 01, 2016 at 12:58:46PM +0200, Abdiel Janulgue wrote:
> > > Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>
> How is the bug that this commit fixes triggered? Reverting this change seems to
> fix [1] which, if I understand correctly, is caused by the atomic commit of
> set_dpms() to be waiting for the dummy write to the frontbuffer complete, while
> the spin batch never ends since the test is blocked and so doesn't handle the
> timer signal.
That is actually a kernel regression (that I'm responsible for). However
it raises a good point that we don't actually want to interrupt the
modeset to handle the signal in this case, otherwise the interrupt
modeset and when it restarts, it will find it doesn't have to wait -
invalidating our test that it can wait for completion. Hmm, that affects
all users. We want to delegate that task to a thread/child to avoid
interrupting the syscall and perturbing the actual code under test.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-24 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 10:58 [i-g-t PATCH 1/2] igt_dummyload: clear signal handler on the desructor Abdiel Janulgue
2016-12-01 10:58 ` [i-g-t PATCH 2/2] igt/kms_flip: Fix set_dpms called with an idle bo Abdiel Janulgue
2016-12-01 11:23 ` Chris Wilson
2017-03-24 11:55 ` Ander Conselvan De Oliveira
2017-03-24 12:11 ` Chris Wilson [this message]
2016-12-01 11:23 ` [i-g-t PATCH 1/2] igt_dummyload: clear signal handler on the desructor Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324121141.GE9495@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.