All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	linux-mm@kvack.org, hch@lst.de, jszhang@marvell.com,
	joelaf@google.com, chris@chris-wilson.co.uk, joaodias@google.com,
	tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu
Subject: Re: [PATCH] mm: Remove pointless might_sleep() in remove_vm_area().
Date: Fri, 24 Mar 2017 09:17:32 -0700	[thread overview]
Message-ID: <20170324161732.GA23110@bombadil.infradead.org> (raw)
In-Reply-To: <fe511b26-f2e5-0a0e-09cc-303d38d2ad05@virtuozzo.com>

On Fri, Mar 24, 2017 at 06:05:45PM +0300, Andrey Ryabinin wrote:
> Just fix the drm code. There is zero point in releasing memory under spinlock.

I disagree.  The spinlock has to be held while deleting from the hash
table.  Sure, we could change the API to return the object removed, and
then force the caller to free the object that was removed from the hash
table outside the lock it's holding, but that's a really inelegant API.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-03-24 16:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 10:53 [PATCH] mm: Remove pointless might_sleep() in remove_vm_area() Tetsuo Handa
2017-03-24 12:22 ` Andrey Ryabinin
2017-03-24 12:40   ` Tetsuo Handa
2017-03-24 15:05     ` Andrey Ryabinin
2017-03-24 16:17       ` Matthew Wilcox [this message]
2017-03-27 13:26         ` Andrey Ryabinin
2017-03-27 14:06           ` Matthew Wilcox
2017-03-27 14:10           ` Thomas Hellstrom
2017-03-27 14:29             ` Tetsuo Handa
2017-03-27 14:29               ` Tetsuo Handa
2017-03-27 15:02               ` Andrey Ryabinin
2017-03-27 15:02                 ` Andrey Ryabinin
2017-03-28 10:07                 ` Tetsuo Handa
2017-03-28 10:07                   ` Tetsuo Handa
2017-03-24 22:47       ` Tetsuo Handa
2017-03-27 10:16         ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324161732.GA23110@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=joaodias@google.com \
    --cc=joelaf@google.com \
    --cc=jszhang@marvell.com \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.