From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v1] mempool/dpaa2: add DPAA2 hardware
 offloaded mempool
Date: Fri, 24 Mar 2017 17:42:46 +0100
Message-ID: <20170324174246.4d04a21f@platinum>
References: <1489754838-1455-1-git-send-email-hemant.agrawal@nxp.com>
 <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com>
 <7d898278-9331-0c72-cabd-9318c6d65f1e@intel.com>
 <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com>
 <20170324173146.477a5157@platinum>
 <434e5f68-430b-1676-fed8-3527f25f3081@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org,
 thomas.monjalon@6wind.com, shreyansh.jain@nxp.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com
 [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id A593136E
 for <dev@dpdk.org>; Fri, 24 Mar 2017 17:42:49 +0100 (CET)
Received: by mail-wr0-f174.google.com with SMTP id u108so5333646wrb.3
 for <dev@dpdk.org>; Fri, 24 Mar 2017 09:42:49 -0700 (PDT)
In-Reply-To: <434e5f68-430b-1676-fed8-3527f25f3081@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 24 Mar 2017 16:38:04 +0000, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 3/24/2017 4:31 PM, Olivier Matz wrote:
> > Hi Ferruh,
> > 
> > On Fri, 24 Mar 2017 15:59:50 +0000, Ferruh Yigit <ferruh.yigit@intel.com> wrote:  
> >> On 3/24/2017 2:57 PM, Ferruh Yigit wrote:  
> >>> On 3/17/2017 12:47 PM, Hemant Agrawal wrote:    
> >>>> DPAA2 Hardware Mempool handlers allow enqueue/dequeue from NXP's
> >>>> QBMAN hardware block.
> >>>> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS is set to 'dpaa2', if the pool
> >>>> is enabled.
> >>>>
> >>>> This memory pool currently supports packet mbuf type blocks only.
> >>>>
> >>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>    
> >>>
> >>> Applied to dpdk-next-net/master, thanks.    
> >>
> >> Hi Olivier,
> >>
> >> I get this to next-net, since dpaa2 net driver depends this one.
> >>
> >> But were you planning any review on the code? Or is it good to go as it is?  
> > 
> > Yes, but I'm afraid I won't be able to do it today.  
> 
> OK, when you done your review, we can act according its result.
> 
> I just want to remind the dependency chain, dpaa2 net depends this
> patch, and dpaa2 crypto depends net one.
> An early integration from next-net required so that next-crypto can
> finish its work before integration deadline.

Understood. Thanks.


> 
> Thanks,
> ferruh
> 
> > 
> > From high level, I'm still a little puzzled by the amount of references
> > to mbuf in a mempool handler code, which should theorically handle any
> > kind of objects.
> > 
> > Is it planned to support other kind of objects?
> > Does this driver passes the mempool autotest?
> > Can the user be aware of these limitations?
> > 
> > 
> > Thanks,
> > Olivier
> >   
>