From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v5 04/20] event/sw: add configure function
Date: Sat, 25 Mar 2017 18:47:07 +0530
Message-ID: <20170325131706.qbuth227v4tczrxv@localhost.localdomain>
References: <489175012-101439-1-git-send-email-harry.van.haaren@intel.com>
 <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com>
 <1490374395-149320-5-git-send-email-harry.van.haaren@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0068.outbound.protection.outlook.com [104.47.41.68])
 by dpdk.org (Postfix) with ESMTP id 8F10BF618
 for <dev@dpdk.org>; Sat, 25 Mar 2017 14:17:30 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1490374395-149320-5-git-send-email-harry.van.haaren@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 24, 2017 at 04:52:59PM +0000, Harry van Haaren wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>  drivers/event/sw/sw_evdev.c | 15 +++++++++++++++
>  drivers/event/sw/sw_evdev.h | 11 +++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index 9d8517a..28a2326 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -44,6 +44,20 @@
>  #define SCHED_QUANTA_ARG "sched_quanta"
>  #define CREDIT_QUANTA_ARG "credit_quanta"
>  
> +static int
> +sw_dev_configure(const struct rte_eventdev *dev)
> +{
> +	struct sw_evdev *sw = sw_pmd_priv(dev);
> +	const struct rte_eventdev_data *data = dev->data;
> +	const struct rte_event_dev_config *conf = &data->dev_conf;
> +
> +	sw->qid_count = conf->nb_event_queues;
> +	sw->port_count = conf->nb_event_ports;
> +	sw->nb_events_limit = conf->nb_events_limit;

I think, we can add a check here to detect the unavailability of
per dequeue timeout support in the configure stage.

if (conf->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT)
	return -ENOTSUP;


With that change,

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>