All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas@southpole.se>
To: ofono@ofono.org
Subject: [PATCH udev 04/15] udev: get udev property via lib function
Date: Sat, 25 Mar 2017 17:57:54 +0100	[thread overview]
Message-ID: <20170325165805.28166-5-jonas@southpole.se> (raw)
In-Reply-To: <20170325165805.28166-1-jonas@southpole.se>

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

---
 plugins/udev.c | 24 +++---------------------
 1 file changed, 3 insertions(+), 21 deletions(-)

diff --git a/plugins/udev.c b/plugins/udev.c
index 196c528..7c090aa 100644
--- a/plugins/udev.c
+++ b/plugins/udev.c
@@ -55,34 +55,16 @@ static struct ofono_modem *find_modem(const char *devpath)
 	return NULL;
 }
 
-static const char *get_property(struct udev_device *device,
-				char const *property_name)
-{
-	struct udev_list_entry *entry;
-
-	entry = udev_device_get_properties_list_entry(device);
-	while (entry) {
-		const char *name = udev_list_entry_get_name(entry);
-
-		if (g_strcmp0(name, property_name) == 0)
-			return udev_list_entry_get_value(entry);
-
-		entry = udev_list_entry_get_next(entry);
-	}
-
-	return NULL;
-}
-
 static const char *get_driver(struct udev_device *udev_device)
 {
-	return get_property(udev_device, "OFONO_DRIVER");
+	return udev_device_get_property_value(udev_device, "OFONO_DRIVER");
 }
 
 static const char *get_serial(struct udev_device *udev_device)
 {
 	const char *serial;
 
-	serial = get_property(udev_device, "ID_SERIAL_SHORT");
+	serial = udev_device_get_property_value(udev_device, "ID_SERIAL_SHORT");
 
 	if (serial != NULL) {
 		unsigned int i, len = strlen(serial);
@@ -135,7 +117,7 @@ static void add_isi(struct ofono_modem *modem,
 	if (ofono_modem_get_string(modem, "Interface"))
 		return;
 
-	addr = get_property(udev_device, "OFONO_ISI_ADDRESS");
+	addr = udev_device_get_property_value(udev_device, "OFONO_ISI_ADDRESS");
 	if (addr != NULL)
 		ofono_modem_set_integer(modem, "Address", atoi(addr));
 
-- 
2.9.3


  parent reply	other threads:[~2017-03-25 16:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25 16:57 [PATCH udev 00/15] Device handling cleanup series Jonas Bonn
2017-03-25 16:57 ` [PATCH udev 01/15] udevng: simplify logic in check_usb_device Jonas Bonn
2017-03-27  1:46   ` Denis Kenzior
2017-03-27  9:00   ` Lukasz Nowak
2017-03-25 16:57 ` [PATCH udev 02/15] ofono.rules: remove 'change' action Jonas Bonn
2017-03-27  1:46   ` Denis Kenzior
2017-03-25 16:57 ` [PATCH udev 03/15] udev: remove extraneous subsystem check Jonas Bonn
2017-03-27  1:52   ` Denis Kenzior
2017-03-25 16:57 ` Jonas Bonn [this message]
2017-03-27  1:53   ` [PATCH udev 04/15] udev: get udev property via lib function Denis Kenzior
2017-03-25 16:57 ` [PATCH udev 05/15] udev: remove unused modem property Jonas Bonn
2017-03-27  1:53   ` Denis Kenzior
2017-03-25 16:57 ` [PATCH udev 06/15] udev: simplify add_modem Jonas Bonn
2017-03-27  3:09   ` Denis Kenzior
2017-03-25 16:57 ` [PATCH udev 07/15] udev: add common modem registration code Jonas Bonn
2017-03-25 16:57 ` [PATCH udev 08/15] udev: simplify ifx modem registration Jonas Bonn
2017-03-25 16:57 ` [PATCH udev 09/15] udev: simplify wavecom " Jonas Bonn
2017-03-25 16:58 ` [PATCH udev 10/15] udev: remove extraneous subsystem check Jonas Bonn
2017-03-25 16:58 ` [PATCH udev 11/15] udevng: add legacy device handling functions Jonas Bonn
2017-03-27  3:24   ` Denis Kenzior
2017-03-28 12:58     ` Jonas Bonn
2017-03-25 16:58 ` [PATCH udev 12/15] udevng: match on the hsi subsystem for legacy devices Jonas Bonn
2017-03-25 16:58 ` [PATCH udev 13/15] udevng: hook up " Jonas Bonn
2017-03-25 16:58 ` [PATCH udev 14/15] udevng: get properties from interface Jonas Bonn
2017-03-27  3:27   ` Denis Kenzior
2017-03-28 13:07     ` Jonas Bonn
2017-03-28 15:20       ` Denis Kenzior
2017-03-25 16:58 ` [PATCH udev 15/15] plugins: remove udev module Jonas Bonn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170325165805.28166-5-jonas@southpole.se \
    --to=jonas@southpole.se \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.