All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 4/4] Revert "package/sdl2: disable altivec built-in function for PowerPC"
Date: Sat, 25 Mar 2017 22:59:01 +0100	[thread overview]
Message-ID: <20170325215901.15044-4-romain.naour@gmail.com> (raw)
In-Reply-To: <20170325215901.15044-1-romain.naour@gmail.com>

The bug discover while packaging supertux is now fixed by the previous
patch but the issue can still be present in other C++11 package if
-std=c++11 is used on PPC with Altivec vectorization.

This reverts commit d2903aaf1314b50a8a10ce937d2b33c5c42e463e.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/sdl2/sdl2.mk | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/package/sdl2/sdl2.mk b/package/sdl2/sdl2.mk
index 628d906..d2ee50d 100644
--- a/package/sdl2/sdl2.mk
+++ b/package/sdl2/sdl2.mk
@@ -23,16 +23,6 @@ SDL2_CONF_OPTS += \
 # We must enable static build to get compilation successful.
 SDL2_CONF_OPTS += --enable-static
 
-# From https://bugs.debian.org/cgi-bin/bugreport.cgi/?bug=770670
-# "The problem lies within SDL_cpuinfo.h.  It includes altivec.h, which by
-# definition provides an unconditional vector, pixel and bool define in
-# standard-c++ mode.  In GNU-c++ mode this names are only defined
-# context-sensitive by cpp.  SDL_cpuinfo.h is included by SDL.h.
-# Including altivec.h makes arbitrary code break."
-ifeq ($(BR2_POWERPC_CPU_HAS_ALTIVEC),y)
-SDL2_CONF_OPTS += --disable-altivec
-endif
-
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
 SDL2_DEPENDENCIES += udev
 SDL2_CONF_OPTS += --enable-libudev
-- 
2.9.3

  parent reply	other threads:[~2017-03-25 21:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25 21:58 [Buildroot] [PATCH v5 1/4] package/physfs: new package Romain Naour
2017-03-25 21:58 ` [Buildroot] [PATCH v5 2/4] package/supertux: " Romain Naour
2017-04-15 10:15   ` Thomas Petazzoni
2017-03-25 21:59 ` [Buildroot] [PATCH v5 3/4] package/supertux: fix bug when compiling with PPC altivec vectorization Romain Naour
2017-04-15 10:18   ` Thomas Petazzoni
2017-03-25 21:59 ` Romain Naour [this message]
2017-04-15 10:18   ` [Buildroot] [PATCH v5 4/4] Revert "package/sdl2: disable altivec built-in function for PowerPC" Thomas Petazzoni
2017-03-26 20:39 ` [Buildroot] [PATCH v5 1/4] package/physfs: new package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170325215901.15044-4-romain.naour@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.