From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751277AbdCYXdo (ORCPT ); Sat, 25 Mar 2017 19:33:44 -0400 Received: from relay-1.mailobj.net ([213.182.54.6]:60440 "EHLO relay-1.mailobj.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbdCYXdm (ORCPT ); Sat, 25 Mar 2017 19:33:42 -0400 X-Greylist: delayed 533 seconds by postgrey-1.27 at vger.kernel.org; Sat, 25 Mar 2017 19:33:42 EDT X-EA-Auth: /croeZzIhE++ylpENma5Nx84wI+C56YkSnxmJnKakptlHugOh5dLa5w2Sy9So5XK0VA505l17b/bEWOdxpONVOLDzLCallNiBb8d/Kx4eAM= Date: Sun, 26 Mar 2017 00:24:14 +0100 From: Guillaume Brogi To: Greg Kroah-Hartman , Bhumika Goyal , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Convert __le16 to cpu before casting to u32 Message-ID: <20170325232414.bqqgsm74wjvkcky4@nexon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: NeoMutt/20170306-28-66e702 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following sparse warnings: drivers/staging/rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted __le16 drivers/staging/rtl8192u/r8192U_dm.c:2308:44: warning: cast from restricted __le16 drivers/staging/rtl8192u/r8192U_dm.c:2309:44: warning: cast from restricted __le16 Those three members of qos_parameters are indeed __le16 so they should be converted to the cpu's endianness before being cast to u32. The lines are over the 80 character limit. They already were, and, for the sake of readability, I don't think they should be split. Signed-off-by: Guillaume Brogi --- drivers/staging/rtl8192u/r8192U_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 9209aad0515e..5946c1f8d37d 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -2304,9 +2304,9 @@ static void dm_check_edca_turbo( /* For Each time updating EDCA parameter, reset EDCA turbo mode status. */ dm_init_edca_turbo(dev); u1bAIFS = qos_parameters->aifs[0] * ((mode&(IEEE_G|IEEE_N_24G)) ? 9 : 20) + aSifsTime; - u4bAcParam = (((u32)(qos_parameters->tx_op_limit[0])) << AC_PARAM_TXOP_LIMIT_OFFSET)| - (((u32)(qos_parameters->cw_max[0])) << AC_PARAM_ECW_MAX_OFFSET)| - (((u32)(qos_parameters->cw_min[0])) << AC_PARAM_ECW_MIN_OFFSET)| + u4bAcParam = (((u32)le16_to_cpu(qos_parameters->tx_op_limit[0])) << AC_PARAM_TXOP_LIMIT_OFFSET) | + (((u32)le16_to_cpu(qos_parameters->cw_max[0])) << AC_PARAM_ECW_MAX_OFFSET) | + (((u32)le16_to_cpu(qos_parameters->cw_min[0])) << AC_PARAM_ECW_MIN_OFFSET) | ((u32)u1bAIFS << AC_PARAM_AIFS_OFFSET); /*write_nic_dword(dev, WDCAPARA_ADD[i], u4bAcParam);*/ write_nic_dword(dev, EDCAPARA_BE, u4bAcParam); -- 2.12.1