From: Liam Breck <liam@networkimprov.net>
To: "Andrew F. Davis" <afd@ti.com>, linux-pm@vger.kernel.org
Subject: [PATCH v12 0/5] bq27xxx_battery partial series
Date: Mon, 27 Mar 2017 00:41:54 -0700 [thread overview]
Message-ID: <20170327074159.16213-1-liam@networkimprov.net> (raw)
Andrew, here are the bq27xxx related patches, revised and refactored from your feedback. I
refactored with a somewhat diff mix than you suggested for the sake of readability.
Changes prior to refactoring:
https://github.com/networkimprov/linux/commit/a9c984f0
https://github.com/networkimprov/linux/commit/59fb17ac
I didn't take these 5 suggestions:
/* BlockDataControl() -> Block Data Control, etc
I prefer terms from the docs so that searches in docs for the comment string work.
/* Reports EINVAL ...
This is obvious from the code.
Error reporting
You and Sebastian differ, so I dropped the patch, leaving dev_dbg in I/O methods. Pls resolve in a
future patchset.
checksum_dm_block()
That code came from bqtool, which I don't want to second guess.
/* This sequence is toxic
It's essential to document a specific feature which must not be added to the code. I revised the
comment.
next reply other threads:[~2017-03-27 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 7:41 Liam Breck [this message]
2017-03-27 7:41 ` [PATCH v12 5/9] power: bq27xxx_battery: Add bulk transfer bus methods Liam Breck
2017-03-27 14:49 ` Andrew F. Davis
2017-03-27 19:34 ` Liam Breck
2017-03-27 7:41 ` [PATCH v12 6/9] power: bq27xxx_battery: Add chip data memory read/write support Liam Breck
2017-03-27 14:58 ` Andrew F. Davis
2017-03-27 19:52 ` Liam Breck
2017-03-27 7:41 ` [PATCH v12 7/9] power: bq27xxx_battery: Add power_supply_battery_info support Liam Breck
2017-03-27 15:01 ` Andrew F. Davis
2017-03-27 20:52 ` Liam Breck
2017-03-28 6:29 ` Liam Breck
2017-03-28 19:19 ` Liam Breck
2017-03-27 7:41 ` [PATCH v12 8/9] power: bq27xxx_battery: Enable chip data memory update for certain chips Liam Breck
2017-03-27 15:05 ` Andrew F. Davis
2017-03-27 21:12 ` Liam Breck
2017-03-27 7:41 ` [PATCH v12 9/9] power: bq27xxx_battery: Remove duplicate register arrays Liam Breck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327074159.16213-1-liam@networkimprov.net \
--to=liam@networkimprov.net \
--cc=afd@ti.com \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.