All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
@ 2017-03-27  9:57 ` Tobias Regnery
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Regnery @ 2017-03-27  9:57 UTC (permalink / raw)
  To: maxime.ripard, linux-kernel, linux-arm-kernel, linux-clk; +Cc: Tobias Regnery

With CONFIG_RESET_CONTROLLER=n we get the following link error in the
sunxi-ng clk driver:

drivers/built-in.o: In function `sunxi_ccu_probe':
mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'

Fix this by adding the appropriate select statement.

Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 213cf64e4fab..8af8f4be8e3b 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -1,6 +1,7 @@
 config SUNXI_CCU
 	bool "Clock support for Allwinner SoCs"
 	depends on ARCH_SUNXI || COMPILE_TEST
+	select RESET_CONTROLLER
 	default ARCH_SUNXI
 
 if SUNXI_CCU
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
@ 2017-03-27  9:57 ` Tobias Regnery
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Regnery @ 2017-03-27  9:57 UTC (permalink / raw)
  To: linux-arm-kernel

With CONFIG_RESET_CONTROLLER=n we get the following link error in the
sunxi-ng clk driver:

drivers/built-in.o: In function `sunxi_ccu_probe':
mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'

Fix this by adding the appropriate select statement.

Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 213cf64e4fab..8af8f4be8e3b 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -1,6 +1,7 @@
 config SUNXI_CCU
 	bool "Clock support for Allwinner SoCs"
 	depends on ARCH_SUNXI || COMPILE_TEST
+	select RESET_CONTROLLER
 	default ARCH_SUNXI
 
 if SUNXI_CCU
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
  2017-03-27  9:57 ` Tobias Regnery
  (?)
@ 2017-03-27 11:37   ` Maxime Ripard
  -1 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2017-03-27 11:37 UTC (permalink / raw)
  To: Tobias Regnery; +Cc: linux-kernel, linux-arm-kernel, linux-clk

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

On Mon, Mar 27, 2017 at 11:57:53AM +0200, Tobias Regnery wrote:
> With CONFIG_RESET_CONTROLLER=n we get the following link error in the
> sunxi-ng clk driver:
> 
> drivers/built-in.o: In function `sunxi_ccu_probe':
> mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
> mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'
> 
> Fix this by adding the appropriate select statement.
> 
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
@ 2017-03-27 11:37   ` Maxime Ripard
  0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2017-03-27 11:37 UTC (permalink / raw)
  To: Tobias Regnery; +Cc: linux-kernel, linux-arm-kernel, linux-clk


[-- Attachment #1.1: Type: text/plain, Size: 690 bytes --]

On Mon, Mar 27, 2017 at 11:57:53AM +0200, Tobias Regnery wrote:
> With CONFIG_RESET_CONTROLLER=n we get the following link error in the
> sunxi-ng clk driver:
> 
> drivers/built-in.o: In function `sunxi_ccu_probe':
> mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
> mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'
> 
> Fix this by adding the appropriate select statement.
> 
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
@ 2017-03-27 11:37   ` Maxime Ripard
  0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2017-03-27 11:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Mar 27, 2017 at 11:57:53AM +0200, Tobias Regnery wrote:
> With CONFIG_RESET_CONTROLLER=n we get the following link error in the
> sunxi-ng clk driver:
> 
> drivers/built-in.o: In function `sunxi_ccu_probe':
> mux-core.c:(.text+0x12fe68): undefined reference to 'reset_controller_register'
> mux-core.c:(.text+0x12fe68): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol 'reset_controller_register'
> 
> Fix this by adding the appropriate select statement.
> 
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170327/94690a35/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-27 11:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-27  9:57 [PATCH] clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER Tobias Regnery
2017-03-27  9:57 ` Tobias Regnery
2017-03-27 11:37 ` Maxime Ripard
2017-03-27 11:37   ` Maxime Ripard
2017-03-27 11:37   ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.