From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.fireflyinternet.com ([109.228.58.192]:58421 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753350AbdC0MZY (ORCPT ); Mon, 27 Mar 2017 08:25:24 -0400 Date: Mon, 27 Mar 2017 13:25:04 +0100 From: Chris Wilson To: Joonas Lahtinen Cc: intel-gfx@lists.freedesktop.org, "# v4 . 9" Subject: Re: [PATCH] drm/i915: Check we have an wake device before flushing GTT writes Message-ID: <20170327122504.GM10606@nuc-i3427.alporthouse.com> References: <20170308124057.6512-1-chris@chris-wilson.co.uk> <20170323150053.28582-1-chris@chris-wilson.co.uk> <1490610558.3166.15.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1490610558.3166.15.camel@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Mar 27, 2017 at 01:29:18PM +0300, Joonas Lahtinen wrote: > On to, 2017-03-23 at 15:00 +0000, Chris Wilson wrote: > > We can assume that if the device is asleep then all pending GTT writes > > will have been posted, and so we can defer the flush from > > i915_gem_object_flush_gtt_write_domain() > > > > [ 1957.462568] WARNING: CPU: 0 PID: 6132 at drivers/gpu/drm/i915/intel_drv.h:1742 fwtable_read32+0x123/0x150 [i915] > > [ 1957.462582] RPM wakelock ref not held during HW access > > [ 1957.462583] Modules linked in: i915 intel_gtt drm_kms_helper prime_numbers > > [ 1957.462607] CPU: 0 PID: 6132 Comm: gem_concurrent_ Tainted: G�����U����������4.11.0-rc1+ #464 > > [ 1957.462619] Hardware name:������������������/��������, BIOS PYBSWCEL.86A.0027.2015.0507.1758 05/07/2015 > > [ 1957.462630] Call Trace: > > [ 1957.462646]��dump_stack+0x4d/0x6f > > [ 1957.462657]��__warn+0xc1/0xe0 > > [ 1957.462667]��warn_slowpath_fmt+0x4a/0x50 > > [ 1957.462709]��fwtable_read32+0x123/0x150 [i915] > > [ 1957.462750]��i915_gem_object_flush_gtt_write_domain+0x43/0x70 [i915] > > [ 1957.462791]��i915_gem_object_set_to_cpu_domain+0x46/0xa0 [i915] > > [ 1957.462831]��i915_gem_set_domain_ioctl+0x15d/0x220 [i915] > > [ 1957.462843]��drm_ioctl+0x1d7/0x440 > > [ 1957.462885]��? i915_gem_obj_prepare_shmem_write+0x1d0/0x1d0 [i915] > > [ 1957.462896]��? pick_next_task_fair+0x436/0x440 > > [ 1957.462906]��? mntput+0x1f/0x30 > > [ 1957.462915]��do_vfs_ioctl+0x8f/0x5c0 > > [ 1957.462925]��? __schedule+0x16f/0x5f0 > > [ 1957.462935]��? ____fput+0x9/0x10 > > [ 1957.462943]��SyS_ioctl+0x3c/0x70 > > [ 1957.462952]��entry_SYSCALL_64_fastpath+0x17/0x98 > > [ 1957.462961] RIP: 0033:0x7fc542179ca7 > > [ 1957.462968] RSP: 002b:00007ffeef12ff98 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > > [ 1957.462982] RAX: ffffffffffffffda RBX: 00007ffeef1301d0 RCX: 00007fc542179ca7 > > [ 1957.462990] RDX: 00007ffeef12ffd0 RSI: 00000000400c645f RDI: 0000000000000003 > > [ 1957.462999] RBP: 0000000000000003 R08: 000055f433bc7c40 R09: 000000000000002c > > [ 1957.463006] R10: 0000000000000073 R11: 0000000000000246 R12: 0000000000000018 > > [ 1957.463015] R13: 000055f432c89d20 R14: 000055f432c87690 R15: 0000000000000000 > > > > Fixes: 3b5724d702ef ("drm/i915: Wait for writes through the GTT to land before reading back") > > Signed-off-by: Chris Wilson > > Cc: Joonas Lahtinen > > Cc: # v4.9 > > Reviewed-by: Joonas Lahtinen Ta, one less warning (not yet seen by CI, come on CI stop slacking)! -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Check we have an wake device before flushing GTT writes Date: Mon, 27 Mar 2017 13:25:04 +0100 Message-ID: <20170327122504.GM10606@nuc-i3427.alporthouse.com> References: <20170308124057.6512-1-chris@chris-wilson.co.uk> <20170323150053.28582-1-chris@chris-wilson.co.uk> <1490610558.3166.15.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12ED96E1CB for ; Mon, 27 Mar 2017 12:25:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1490610558.3166.15.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: intel-gfx@lists.freedesktop.org, "# v4 . 9" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjcsIDIwMTcgYXQgMDE6Mjk6MThQTSArMDMwMCwgSm9vbmFzIExhaHRpbmVu IHdyb3RlOgo+IE9uIHRvLCAyMDE3LTAzLTIzIGF0IDE1OjAwICswMDAwLCBDaHJpcyBXaWxzb24g d3JvdGU6Cj4gPiBXZSBjYW4gYXNzdW1lIHRoYXQgaWYgdGhlIGRldmljZSBpcyBhc2xlZXAgdGhl biBhbGwgcGVuZGluZyBHVFQgd3JpdGVzCj4gPiB3aWxsIGhhdmUgYmVlbiBwb3N0ZWQsIGFuZCBz byB3ZSBjYW4gZGVmZXIgdGhlIGZsdXNoIGZyb20KPiA+IGk5MTVfZ2VtX29iamVjdF9mbHVzaF9n dHRfd3JpdGVfZG9tYWluKCkKPiA+IAo+ID4gWyAxOTU3LjQ2MjU2OF0gV0FSTklORzogQ1BVOiAw IFBJRDogNjEzMiBhdCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaDoxNzQyIGZ3dGFi bGVfcmVhZDMyKzB4MTIzLzB4MTUwIFtpOTE1XQo+ID4gWyAxOTU3LjQ2MjU4Ml0gUlBNIHdha2Vs b2NrIHJlZiBub3QgaGVsZCBkdXJpbmcgSFcgYWNjZXNzCj4gPiBbIDE5NTcuNDYyNTgzXSBNb2R1 bGVzIGxpbmtlZCBpbjogaTkxNSBpbnRlbF9ndHQgZHJtX2ttc19oZWxwZXIgcHJpbWVfbnVtYmVy cwo+ID4gWyAxOTU3LjQ2MjYwN10gQ1BVOiAwIFBJRDogNjEzMiBDb21tOiBnZW1fY29uY3VycmVu dF8gVGFpbnRlZDogR8KgwqDCoMKgwqBVwqDCoMKgwqDCoMKgwqDCoMKgwqA0LjExLjAtcmMxKyAj NDY0Cj4gPiBbIDE5NTcuNDYyNjE5XSBIYXJkd2FyZSBuYW1lOsKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoC/CoMKgwqDCoMKgwqDCoMKgLCBCSU9TIFBZQlNXQ0VMLjg2QS4wMDI3 LjIwMTUuMDUwNy4xNzU4IDA1LzA3LzIwMTUKPiA+IFsgMTk1Ny40NjI2MzBdIENhbGwgVHJhY2U6 Cj4gPiBbIDE5NTcuNDYyNjQ2XcKgwqBkdW1wX3N0YWNrKzB4NGQvMHg2Zgo+ID4gWyAxOTU3LjQ2 MjY1N13CoMKgX193YXJuKzB4YzEvMHhlMAo+ID4gWyAxOTU3LjQ2MjY2N13CoMKgd2Fybl9zbG93 cGF0aF9mbXQrMHg0YS8weDUwCj4gPiBbIDE5NTcuNDYyNzA5XcKgwqBmd3RhYmxlX3JlYWQzMisw eDEyMy8weDE1MCBbaTkxNV0KPiA+IFsgMTk1Ny40NjI3NTBdwqDCoGk5MTVfZ2VtX29iamVjdF9m bHVzaF9ndHRfd3JpdGVfZG9tYWluKzB4NDMvMHg3MCBbaTkxNV0KPiA+IFsgMTk1Ny40NjI3OTFd wqDCoGk5MTVfZ2VtX29iamVjdF9zZXRfdG9fY3B1X2RvbWFpbisweDQ2LzB4YTAgW2k5MTVdCj4g PiBbIDE5NTcuNDYyODMxXcKgwqBpOTE1X2dlbV9zZXRfZG9tYWluX2lvY3RsKzB4MTVkLzB4MjIw IFtpOTE1XQo+ID4gWyAxOTU3LjQ2Mjg0M13CoMKgZHJtX2lvY3RsKzB4MWQ3LzB4NDQwCj4gPiBb IDE5NTcuNDYyODg1XcKgwqA/IGk5MTVfZ2VtX29ial9wcmVwYXJlX3NobWVtX3dyaXRlKzB4MWQw LzB4MWQwIFtpOTE1XQo+ID4gWyAxOTU3LjQ2Mjg5Nl3CoMKgPyBwaWNrX25leHRfdGFza19mYWly KzB4NDM2LzB4NDQwCj4gPiBbIDE5NTcuNDYyOTA2XcKgwqA/IG1udHB1dCsweDFmLzB4MzAKPiA+ IFsgMTk1Ny40NjI5MTVdwqDCoGRvX3Zmc19pb2N0bCsweDhmLzB4NWMwCj4gPiBbIDE5NTcuNDYy OTI1XcKgwqA/IF9fc2NoZWR1bGUrMHgxNmYvMHg1ZjAKPiA+IFsgMTk1Ny40NjI5MzVdwqDCoD8g X19fX2ZwdXQrMHg5LzB4MTAKPiA+IFsgMTk1Ny40NjI5NDNdwqDCoFN5U19pb2N0bCsweDNjLzB4 NzAKPiA+IFsgMTk1Ny40NjI5NTJdwqDCoGVudHJ5X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxNy8w eDk4Cj4gPiBbIDE5NTcuNDYyOTYxXSBSSVA6IDAwMzM6MHg3ZmM1NDIxNzljYTcKPiA+IFsgMTk1 Ny40NjI5NjhdIFJTUDogMDAyYjowMDAwN2ZmZWVmMTJmZjk4IEVGTEFHUzogMDAwMDAyNDYgT1JJ R19SQVg6IDAwMDAwMDAwMDAwMDAwMTAKPiA+IFsgMTk1Ny40NjI5ODJdIFJBWDogZmZmZmZmZmZm ZmZmZmZkYSBSQlg6IDAwMDA3ZmZlZWYxMzAxZDAgUkNYOiAwMDAwN2ZjNTQyMTc5Y2E3Cj4gPiBb IDE5NTcuNDYyOTkwXSBSRFg6IDAwMDA3ZmZlZWYxMmZmZDAgUlNJOiAwMDAwMDAwMDQwMGM2NDVm IFJESTogMDAwMDAwMDAwMDAwMDAwMwo+ID4gWyAxOTU3LjQ2Mjk5OV0gUkJQOiAwMDAwMDAwMDAw MDAwMDAzIFIwODogMDAwMDU1ZjQzM2JjN2M0MCBSMDk6IDAwMDAwMDAwMDAwMDAwMmMKPiA+IFsg MTk1Ny40NjMwMDZdIFIxMDogMDAwMDAwMDAwMDAwMDA3MyBSMTE6IDAwMDAwMDAwMDAwMDAyNDYg UjEyOiAwMDAwMDAwMDAwMDAwMDE4Cj4gPiBbIDE5NTcuNDYzMDE1XSBSMTM6IDAwMDA1NWY0MzJj ODlkMjAgUjE0OiAwMDAwNTVmNDMyYzg3NjkwIFIxNTogMDAwMDAwMDAwMDAwMDAwMAo+ID4gCj4g PiBGaXhlczogM2I1NzI0ZDcwMmVmICgiZHJtL2k5MTU6IFdhaXQgZm9yIHdyaXRlcyB0aHJvdWdo IHRoZSBHVFQgdG8gbGFuZCBiZWZvcmUgcmVhZGluZyBiYWNrIikKPiA+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiA8c3RhYmxl QHZnZXIua2VybmVsLm9yZz4gIyB2NC45Cj4gCj4gUmV2aWV3ZWQtYnk6IEpvb25hcyBMYWh0aW5l biA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KClRhLCBvbmUgbGVzcyB3YXJuaW5n IChub3QgeWV0IHNlZW4gYnkgQ0ksIGNvbWUgb24gQ0kgc3RvcCBzbGFja2luZykhCi1DaHJpcwoK LS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==