[PATCH v3] MIPS: PCI: add controllers before the specified head

[PATCH v3] MIPS: PCI: add controllers before the specified head

[Mathias Kresin]

With commit 23dac14d058f ("MIPS: PCI: Use struct list_head lists") new
controllers are added after the specified head where they where added
before the specified head previously.

Use list_add_tail to restore the former order.

This patches fixes the following PCI error on lantiq:

  pci 0000:01:00.0: BAR 0: error updating (0x1c000004 != 0x000000)

Fixes: 23dac14d058f ("MIPS: PCI: Use struct list_head lists")
Signed-off-by: Mathias Kresin <dev@kresin.me>

---

Changes in v3:
- fix the list order instead of adjusting the controller scan order
- update commit message accordingly

Changes in v2:
- fix formal issues in commit message (Sergei Shtylyov)

 arch/mips/pci/pci-legacy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pci/pci-legacy.c b/arch/mips/pci/pci-legacy.c
index 014649b..3a84f6c 100644
--- a/arch/mips/pci/pci-legacy.c
+++ b/arch/mips/pci/pci-legacy.c
@@ -190,7 +190,7 @@ void register_pci_controller(struct pci_controller *hose)
 	}
 
 	INIT_LIST_HEAD(&hose->list);
-	list_add(&hose->list, &controllers);
+	list_add_tail(&hose->list, &controllers);
 
 	/*
 	 * Do not panic here but later - this might happen before console init.
-- 
2.7.4

Re: [PATCH v3] MIPS: PCI: add controllers before the specified head

[Sergei Shtylyov]

Hello!

On 3/26/2017 8:05 PM, Mathias Kresin wrote:

> With commit 23dac14d058f ("MIPS: PCI: Use struct list_head lists") new
> controllers are added after the specified head where they where added

    s/where/were//

> before the specified head previously.
>
> Use list_add_tail to restore the former order.
>
> This patches fixes the following PCI error on lantiq:
>
>   pci 0000:01:00.0: BAR 0: error updating (0x1c000004 != 0x000000)
>
> Fixes: 23dac14d058f ("MIPS: PCI: Use struct list_head lists")
> Signed-off-by: Mathias Kresin <dev@kresin.me>

[...]

MBR, Sergei

Re: [PATCH v3] MIPS: PCI: add controllers before the specified head

[Ralf Baechle]

On Sun, Mar 26, 2017 at 07:05:36PM +0200, Mathias Kresin wrote:

> 
> With commit 23dac14d058f ("MIPS: PCI: Use struct list_head lists") new
> controllers are added after the specified head where they where added
> before the specified head previously.
> 
> Use list_add_tail to restore the former order.
> 
> This patches fixes the following PCI error on lantiq:
> 
>   pci 0000:01:00.0: BAR 0: error updating (0x1c000004 != 0x000000)
> 
> Fixes: 23dac14d058f ("MIPS: PCI: Use struct list_head lists")
> Signed-off-by: Mathias Kresin <dev@kresin.me>

Thanks Mathias, will apply.

Had I replied earlier, I would have requested the change you did yourself
in v3.  It seems to me the more logic solution and also closer to the
code before Paul's 23dac14d058f changed it.

I'm going to take care of Sergei's nit also, no need to resend.

  Ralf