From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH 1/1] net/mlx4: add port parameter Date: Mon, 27 Mar 2017 17:46:08 +0200 Message-ID: <20170327154608.GJ2956@bidouze.vm.6wind.com> References: <4b91170d-4696-5207-50ba-4d7e0d10b023@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, Adrien Mazarguil , Nelio Laranjeiro To: Ferruh Yigit Return-path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 5ABB92BE1 for ; Mon, 27 Mar 2017 17:46:17 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id l43so62631342wre.1 for ; Mon, 27 Mar 2017 08:46:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4b91170d-4696-5207-50ba-4d7e0d10b023@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On Mon, Mar 27, 2017 at 04:08:51PM +0100, Ferruh Yigit wrote: >On 3/3/2017 3:40 PM, Gaetan Rivet wrote: >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus >> address. >> >> Add a new port parameter allowing the user to choose >> either or both physical ports to be used by the application. >> >> This parameter is used as follows: >> >> Selecting only the second port: >> -w 00:00.0,port=1 >> >> Selecting both ports: >> -w 00:00.0,port=0,port=1 >> >> If no parameter is given, the default behavior is unchanged: all ports >> are probed. >> >> Signed-off-by: Gaetan Rivet > >Hi Gaetan, > >Getting following checkpatch warning [1], can you please address it? > Sure, here it is: http://dpdk.org/ml/archives/dev/2017-March/061582.html Sorry for that, I was checking it with an older checkpatch.pl. >Thanks, >ferruh > >[1] >WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' >#156: FILE: drivers/net/mlx4/mlx4.c:5462: >+ unsigned arg_count; -- Gaëtan Rivet 6WIND