From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751862AbdC0RGJ (ORCPT ); Mon, 27 Mar 2017 13:06:09 -0400 Received: from verein.lst.de ([213.95.11.211]:42281 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdC0RGB (ORCPT ); Mon, 27 Mar 2017 13:06:01 -0400 Date: Mon, 27 Mar 2017 19:05:40 +0200 From: Christoph Hellwig To: Mike Galbraith Cc: Christoph Hellwig , Thorsten Leemhuis , mst@redhat.com, virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Message-ID: <20170327170540.GA28715@lst.de> References: <20170323145622.GA31690@lst.de> <1490605644.14634.50.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490605644.14634.50.camel@gmx.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, does the patch below fix that issue for you? diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index df548a6fb844..fd1b06368b1f 100644 --- a/drivers/virtio/virtio_pci_common.c +++ b/drivers/virtio/virtio_pci_common.c @@ -176,7 +176,7 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned nvqs, if (err < 0) return err; - vp_dev->msix_vectors = nvectors; + vp_dev->msix_vectors = err; /* number of vectors allocated */ vp_dev->msix_names = kmalloc_array(nvectors, sizeof(*vp_dev->msix_names), GFP_KERNEL); if (!vp_dev->msix_names)