All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	bhelgaas@google.com, davem@davemloft.net,
	netanel@annapurnalabs.com, jcliburn@gmail.com,
	chris.snook@gmail.com, sgoutham@cavium.com, rric@kernel.org,
	netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 5/5] PCI: remove pci_enable_msix
Date: Mon, 27 Mar 2017 19:11:48 +0200	[thread overview]
Message-ID: <20170327171148.GB28815@lst.de> (raw)
In-Reply-To: <83f97789-0817-7549-bfa9-1f8dcb0c26d9@gmail.com>

On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote:
> On 03/27/2017 01:29 AM, Christoph Hellwig wrote:
>> Unused now that all callers switched to pci_alloc_irq_vectors.
>>
>
> And you are aware that the ThunderX GPIO driver that I am attempting to 
> merge uses this interface.
>
> If this patch gets merged, should I ask to revert it when the GPIO driver 
> goes in?

No.  You should not use pci_enable_msix in your new driver as I told
you before.

> You offer no solution for drivers that would benefit from using a sparse 
> sub set of the available MSI-X vectors.

Use pci_enable_msix_{exact,range} for now, as I told you before.

  reply	other threads:[~2017-03-27 17:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  8:29 remove pci_enable_msix() Christoph Hellwig
2017-03-27  8:29 ` [PATCH 1/5] net: thunderx: switch to pci_alloc_irq_vectors Christoph Hellwig
2017-03-27 16:03   ` Sunil Kovvuri
2017-03-27 17:12     ` Christoph Hellwig
2017-03-27  8:29 ` [PATCH 2/5] net: thunderxvf: " Christoph Hellwig
2017-03-27  8:29 ` [PATCH 3/5] net: alx: " Christoph Hellwig
2017-03-27  8:29 ` [PATCH 4/5] net/ena: " Christoph Hellwig
2017-03-27  8:29 ` [PATCH 5/5] PCI: remove pci_enable_msix Christoph Hellwig
2017-03-27 14:06   ` David Laight
2017-03-27 14:51     ` 'Christoph Hellwig'
2017-03-27 15:03       ` David Laight
2017-03-27 17:10         ` 'Christoph Hellwig'
2017-03-27 16:59   ` David Daney
2017-03-27 17:11     ` Christoph Hellwig [this message]
2017-03-27 17:30       ` David Daney
2017-03-28  6:41         ` Christoph Hellwig
2017-03-28 16:24           ` David Daney
2017-03-30 22:56             ` Bjorn Helgaas
2017-03-30 23:00               ` David Daney
2017-03-28  9:07         ` David Laight
2017-03-30 23:09   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327171148.GB28815@lst.de \
    --to=hch@lst.de \
    --cc=bhelgaas@google.com \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=ddaney.cavm@gmail.com \
    --cc=jcliburn@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=netanel@annapurnalabs.com \
    --cc=netdev@vger.kernel.org \
    --cc=rric@kernel.org \
    --cc=sgoutham@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.