All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Gargi Sharma <gs051095@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.orgm,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/4] Constify option structures
Date: Mon, 27 Mar 2017 20:49:40 +0200	[thread overview]
Message-ID: <20170327184940.GA21804@salvia> (raw)
In-Reply-To: <cover.1490640256.git.gs051095@gmail.com>

On Tue, Mar 28, 2017 at 12:15:26AM +0530, Gargi Sharma wrote:
> The struct option is generally used only to initialise
> fields inside certain structs and is not modified anywhere.
> Done using Coccinelle:
> 
> @r1 disable optional_qualifier@
> identifier s,i;
> position p;
> @@
> 
> static struct option i@p[] ={...};
> 
> @ok1@
> identifier r1.i;
> expression e;
> position p;
> @@
> e = i@p
> 
> @bad@
> position p != {r1.p,ok1.p};
> identifier r1.i;
> @@
> e@i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct option i[] = { ... };

Please indicate what userspace tree in the subject, I guess this is
iptables.

And merge them all into one single patch, they are part of the same
logical change.

Thanks!


      parent reply	other threads:[~2017-03-27 18:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 18:45 [PATCH 0/4] Constify option structures Gargi Sharma
2017-03-27 18:45 ` [PATCH 1/4] extensions: libebt_limit: Constify option struct Gargi Sharma
2017-03-27 18:45 ` [PATCH 2/4] extenstions: libebt_mark_m: " Gargi Sharma
2017-03-27 18:45 ` [PATCH 3/4] extensions: libebt_mark: " Gargi Sharma
2017-03-27 18:45 ` [PATCH 4/4] extensions: libebt_nflog: " Gargi Sharma
2017-03-27 18:49 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327184940.GA21804@salvia \
    --to=pablo@netfilter.org \
    --cc=gs051095@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=pablo@netfilter.orgm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.