From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: tlb_batch_add_one()
Date: Wed, 29 Mar 2017 00:52:26 +0000 [thread overview]
Message-ID: <20170328.175226.210187301635964014.davem@davemloft.net> (raw)
There seems to be some disagreement about how the hugepage state is
passed into tlb_batch_add(). It's declared as an integer shift, but
there are call sites that pass it in the old way, as a boolean.
For example, all of the call sites in tlb_batch_pmd_scan(), which
likely should be passing PAGE_SHIFT. Passing true or false in these
spots can't be right.
I also noticed that there appears to be generic support for handling
the need to flush on page size changes during tlb batching, have
a look at __tlb_remove_page_size(), and the new arch overridable
hook tlb_remove_check_page_size_change().
Thanks.
next reply other threads:[~2017-03-29 0:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 0:52 David Miller [this message]
2017-03-30 20:22 ` tlb_batch_add_one() David Miller
2017-03-30 20:47 ` tlb_batch_add_one() Nitin Gupta
2017-03-30 21:25 ` tlb_batch_add_one() David Miller
2017-03-30 21:54 ` tlb_batch_add_one() David Miller
2017-03-30 22:12 ` tlb_batch_add_one() Nitin Gupta
2017-03-30 23:59 ` tlb_batch_add_one() Nitin Gupta
2017-03-31 0:42 ` tlb_batch_add_one() Nitin Gupta
2017-03-31 2:46 ` tlb_batch_add_one() Nitin Gupta
2017-03-31 2:57 ` tlb_batch_add_one() David Miller
2017-03-31 3:12 ` tlb_batch_add_one() Nitin Gupta
2017-03-31 3:34 ` tlb_batch_add_one() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328.175226.210187301635964014.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.