From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csiA6-0006dG-Sq for qemu-devel@nongnu.org; Mon, 27 Mar 2017 23:51:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csiA2-0006fQ-0L for qemu-devel@nongnu.org; Mon, 27 Mar 2017 23:51:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csiA1-0006fL-OF for qemu-devel@nongnu.org; Mon, 27 Mar 2017 23:51:09 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 771D6804E4 for ; Tue, 28 Mar 2017 03:51:08 +0000 (UTC) Date: Mon, 27 Mar 2017 23:51:06 -0400 From: Jeff Cody Message-ID: <20170328035106.GA1135@localhost.localdomain> References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> <20170328023240.GP15423@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328023240.GP15423@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, jdurgin@redhat.com, kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com On Mon, Mar 27, 2017 at 10:32:40PM -0400, Jeff Cody wrote: > On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote: > > This reverts a part of commit 8a47e8e. We're having second thoughts > > on the QAPI schema (and thus the external interface), and haven't > > reached consensus, yet. Issues include: > > > > * BlockdevOptionsRbd member @password-secret isn't actually a > > password, it's a key generated by Ceph. > > > > * We're not sure where member @password-secret belongs (see the > > previous commit). > > > > * How @password-secret interacts with settings from a configuration > > file specified with @conf is undocumented. I suspect it's untested, > > too. > > It's tested, at least to some extent -- it works on my setup; it will > override whatever is set in the conf or the keyring. I can alternate > between /etc/ceph/keyring, or password-secret, or override the user present > in /etc/cep/keyring with a different key via password-secret. > > So I'd suggest dropping that blurb from the commit message. > > I agree with the overall reasoning though behind remove all parameters not > needed for now, so: > > Reviewed-by: Jeff Cody > Wait, hold up on that R-b :) This only seems to revert the comment in the QAPI. You meant to remove the entry from the BlockdevOptionsRbd struct too, right? > > > > Let's avoid painting ourselves into a corner now, and revert the > > feature for 2.9. > > > > Note that users can still configure an authentication key with a > > configuration file. They probably do that anyway if they use Ceph > > outside QEMU as well. > > > > Signed-off-by: Markus Armbruster > > --- > > qapi/block-core.json | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index 6a7ca0b..2e60ab5 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -2618,9 +2618,6 @@ > > # @server: Monitor host address and port. This maps > > # to the "mon_host" Ceph option. > > # > > -# @password-secret: The ID of a QCryptoSecret object providing > > -# the password for the login. > > -# > > # Since: 2.9 > > ## > > { 'struct': 'BlockdevOptionsRbd', > > -- > > 2.7.4 > >