From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([65.50.211.133]:45727 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754530AbdC1Gqh (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 28 Mar 2017 02:46:37 -0400
Date: Mon, 27 Mar 2017 23:28:25 -0700
From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        Andreas Dilger <adilger@dilger.ca>,
        Eric Biggers <ebiggers3@gmail.com>,
        "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] Add initial batch of statx() LTP tests
Message-ID: <20170328062825.GA11567@infradead.org>
References: <20170327164628.GA15147@infradead.org>
 <20170327154003.GA5716@birch.djwong.org>
 <20170307050140.GA12946@infradead.org>
 <20170307000609.GG5280@birch.djwong.org>
 <10435.1488907375@warthog.procyon.org.uk>
 <20170324205322.GA4986@gmail.com>
 <E6DB8461-22DE-496C-8A4A-B0A2F3702750@dilger.ca>
 <23715.1490631926@warthog.procyon.org.uk>
 <23003.1490660007@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23003.1490660007@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Mar 28, 2017 at 01:13:27AM +0100, David Howells wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
> 
> > > That means a filesystem can't simply return non-basic data unconditionally if
> > > possible.  I prefer letting it do so if it doesn't incur any extra I/O
> > > overheads.
> > 
> > This seems like it will lead to userspace expecting certain fields to
> > just be there, and a lot harder to properly verify for tests.  Which btw
> > we all need for these odd behaviors.  If we can't get them any time soon
> > (e.g. before -rc6) I think we'll simply have to revert statx instead of
> > leaving this untested mess in the tree.
> 
> Here you go.  First batch of tests.  Please review - and test:-)

ltp is a trainwreck.  Please send xfstests test like for all other file
system functionality.  You're really trying to make it as hard as
possible for fs developers, don't you?