All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text
Date: Tue, 28 Mar 2017 08:52:48 +0100	[thread overview]
Message-ID: <20170328075248.GA3992@sudip-tp> (raw)
In-Reply-To: <20170327233910.13122-1-paul.gortmaker@windriver.com>

On Mon, Mar 27, 2017 at 07:39:10PM -0400, Paul Gortmaker wrote:
> In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar:
> split out the exar code from 8250_pci") the exar driver got its own
> Kconfig.  However the text for the new option was never changed from
> the original 8250_PCI text, and hence it appears confusing when you
> get asked the same question twice:
> 
>   8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW)
>     8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW)
> 
> Adding to the confusion, is that there is no help text for this new
> option to indicate it is specific to a certain family of cards.
> 
> Fix both issues at the same time, as well as the space vs. tab issues
> introduced in the same commit.
> 
> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

      parent reply	other threads:[~2017-03-28  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 23:39 [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text Paul Gortmaker
2017-03-27 23:39 ` Paul Gortmaker
2017-03-28  7:10 ` Andy Shevchenko
2017-03-28  7:52 ` Sudip Mukherjee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328075248.GA3992@sudip-tp \
    --to=sudipm.mukherjee@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=sudip.mukherjee@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.