All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate
Date: Tue, 28 Mar 2017 11:07:27 +0100	[thread overview]
Message-ID: <20170328100727.GF26523@stefanha-x1.localdomain> (raw)
In-Reply-To: <1490625488-7980-1-git-send-email-den@openvz.org>

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

On Mon, Mar 27, 2017 at 05:38:08PM +0300, Denis V. Lunev wrote:
> Parallels driver should not call bdrv_truncate if the image was opened
> in the read-only mode. Without the patch
>     qemu-img check harddisk.hds
> asserts with
>     bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed.
> 
> Parameters used on the write path are not needed if the image is opened
> in the read-only mode.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Reported-by: Edgar Kaziahmedov <edos@virtuozzo.mipt.ru>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/parallels.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2017-03-28 10:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 14:38 [Qemu-devel] [PATCH 1/1] parallels: wrong call to bdrv_truncate Denis V. Lunev
2017-03-28 10:07 ` Stefan Hajnoczi [this message]
2017-03-28 16:26 ` Kevin Wolf
2017-03-28 17:12   ` Denis V. Lunev
2017-03-29 10:41     ` Kevin Wolf
2017-03-29 13:53       ` Denis V. Lunev
2017-03-29 14:11         ` Kevin Wolf
2017-03-29 14:18           ` Denis V. Lunev
2017-03-29 14:32             ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328100727.GF26523@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=den@openvz.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.