All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
	famz@redhat.com, stefanha@redhat.com, quintela@redhat.com,
	mreitz@redhat.com, peter.maydell@linaro.org, den@openvz.org,
	jsnow@redhat.com, lirans@il.ibm.com
Subject: Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration
Date: Tue, 28 Mar 2017 11:55:45 +0100	[thread overview]
Message-ID: <20170328105544.GE2509@work-vm> (raw)
In-Reply-To: <20170307095323.GB5871@noname.str.redhat.com>

* Kevin Wolf (kwolf@redhat.com) wrote:
> Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > After migration all drives are inactive and savevm will fail with
> > 
> > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev:
> >    Assertion `!(bs->open_flags & 0x0800)' failed.
> > 
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> 
> What's the exact state you're in? I tried to reproduce this, but just
> doing a live migration and then savevm on the destination works fine for
> me.
> 
> Hm... Or do you mean on the source? In that case, I think the operation
> must fail, but of course more gracefully than now.
> 
> Actually, the question that you're asking implicitly here is how the
> source qemu process should be "reactivated" after a failed migration.
> Currently, as far as I know, this is only with issuing a "cont" command.
> It might make sense to provide a way to get control without resuming the
> VM, but I doubt that adding automatic resume to every QMP command is the
> right way to achieve it.
> 
> Dave, Juan, what do you think?

I'd only ever really thought of 'cont' or retrying the migration.
However, it does make sense to me that you might want to do a savevm instead;
if you can't migrate then perhaps a savevm is the best you can do before
your machine dies.  Are there any other things that should be allowed?

We would want to be careful not to accidentally reactivate the disks on the source
after what was actually a succesful migration.

As for the actual patch contents, I'd leave that to you to say if it's
OK from the block side of things.

Dave

> > diff --git a/block/snapshot.c b/block/snapshot.c
> > index bf5c2ca5e1..256d06ac9f 100644
> > --- a/block/snapshot.c
> > +++ b/block/snapshot.c
> > @@ -145,7 +145,8 @@ bool bdrv_snapshot_find_by_id_and_name(BlockDriverState *bs,
> >  int bdrv_can_snapshot(BlockDriverState *bs)
> >  {
> >      BlockDriver *drv = bs->drv;
> > -    if (!drv || !bdrv_is_inserted(bs) || bdrv_is_read_only(bs)) {
> > +    if (!drv || !bdrv_is_inserted(bs) || bdrv_is_read_only(bs) ||
> > +        (bs->open_flags & BDRV_O_INACTIVE)) {
> >          return 0;
> >      }
> 
> I wasn't sure if this doesn't disable too much, but it seems it only
> makes 'info snapshots' turn up empty, which might not be nice, but maybe
> tolerable.
> 
> At least it should definitely fix the assertion.

Did Denis have some concerns about this chunk?

> > diff --git a/migration/savevm.c b/migration/savevm.c
> > index 5ecd264134..75e56d2d07 100644
> > --- a/migration/savevm.c
> > +++ b/migration/savevm.c
> > @@ -2068,6 +2068,17 @@ int save_vmstate(Monitor *mon, const char *name)
> >      Error *local_err = NULL;
> >      AioContext *aio_context;
> >  
> > +    if (runstate_check(RUN_STATE_FINISH_MIGRATE) ||
> > +        runstate_check(RUN_STATE_POSTMIGRATE) ||
> > +        runstate_check(RUN_STATE_PRELAUNCH))
> > +    {
> > +        bdrv_invalidate_cache_all(&local_err);
> > +        if (local_err) {
> > +            error_report_err(local_err);
> > +            return -EINVAL;
> > +        }
> > +    }
> > +
> 
> This hunk can't go in before the more general question of implicitly or
> explicitly regaining control after a failed migration is answered.
> 
> Kevin
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  parent reply	other threads:[~2017-03-28 10:56 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 19:31 [Qemu-devel] [PATCH 0/4] some migration bugs Vladimir Sementsov-Ogievskiy
2017-02-25 19:31 ` [Qemu-devel] [PATCH 1/4] iotests: add migration corner cases test Vladimir Sementsov-Ogievskiy
2017-03-07  9:14   ` Fam Zheng
2017-03-07 11:23   ` Dr. David Alan Gilbert
2017-02-25 19:31 ` [Qemu-devel] [PATCH 2/4] qmp-cont: invalidate on RUN_STATE_PRELAUNCH Vladimir Sementsov-Ogievskiy
2017-03-07  9:19   ` Fam Zheng
2017-03-07 10:02   ` Kevin Wolf
2017-03-07 10:11     ` Vladimir Sementsov-Ogievskiy
2017-03-07 10:22       ` Kevin Wolf
2017-04-26 12:22       ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2017-04-26 13:43         ` Vladimir Sementsov-Ogievskiy
2017-02-25 19:31 ` [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration Vladimir Sementsov-Ogievskiy
2017-02-27  9:42   ` Denis V. Lunev
2017-03-07  9:53   ` Kevin Wolf
2017-03-07  9:59     ` Vladimir Sementsov-Ogievskiy
2017-03-07 11:01       ` Kevin Wolf
2017-03-07 11:20         ` Dr. David Alan Gilbert
2017-03-28 10:55     ` Dr. David Alan Gilbert [this message]
2017-03-28 11:09       ` Kevin Wolf
2017-03-28 11:13         ` Dr. David Alan Gilbert
2017-03-28 12:09           ` Kevin Wolf
2017-03-28 13:16             ` Vladimir Sementsov-Ogievskiy
2017-03-28 14:15               ` Paolo Bonzini
2017-03-29 15:29                 ` Dr. David Alan Gilbert
2017-03-29 15:53                   ` Paolo Bonzini
2017-04-25 14:22                     ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2017-03-28 11:18       ` [Qemu-devel] " Denis V. Lunev
2017-02-25 19:31 ` [Qemu-devel] [PATCH 4/4] migration: fix use-after-free of to_dst_file Vladimir Sementsov-Ogievskiy
2017-02-27 10:44   ` Dr. David Alan Gilbert
2017-02-28  9:59   ` Dr. David Alan Gilbert
2017-03-06 14:23 ` [Qemu-devel] [PATCH 0/4] some migration bugs Denis V. Lunev
2017-03-20  9:44   ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328105544.GE2509@work-vm \
    --to=dgilbert@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lirans@il.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.