From: Andrew Lunn <andrew@lunn.ch>
To: Thomas Scariah <thomasscariah@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
nsekhar@ti.com, grygorii.strashko@ti.com, davem@davemloft.net,
drivshin@allworx.com, mugunthanvnm@ti.com,
ivan.khoronzhuk@linaro.org,
Thomas Scariah <thomas.scariah@harman.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ethtool : added get_phy_stats,get_strings,get_sset_count
Date: Tue, 28 Mar 2017 14:10:29 +0200 [thread overview]
Message-ID: <20170328121029.GB3152@lunn.ch> (raw)
In-Reply-To: <CA+1hMaGV-trVT+ZisgTtyRAVz=ZqopmwmpWyqHvWQMrkmv-96A@mail.gmail.com>
On Tue, Mar 28, 2017 at 11:56:40AM +0530, Thomas Scariah wrote:
> Hello Florian/Andrew,
>
>
> On Mon, Mar 27, 2017 at 10:14 PM, Florian Fainelli <f.fainelli@gmail.com>
> wrote:
>
> > Hello,
> >
> > On 03/27/2017 03:12 AM, Thomas Scariah wrote:
> > > From: "Scariah, Thomas" <thomas.scariah@harman.com>
> > >
> > > Added functions to support ethtool to print the phy statistics and error
> > > information along with other ethtool statistics. This will help ethtool
> > > information to know the error is from physical layer or MAC layer.
> > > This is an enahancement for ethtool to accommodate phy statistics
> >
> > It sounds like your patch should actually be 3 different patches:
> >
> > - add helper function to the core PHY library
> > - add statistics support to the Micrel PHY driver
> > - hook the proper ndo operations in cpsw to allow querying the PHY
> > driver's statistics
> >
>
> Yes agreed. This can be 3 different patches .
> Anyway the latest kernel already has the same change.
> I have developed this patch against Kernel 4.4.14 and the similar
> functionality was not available.
Hi Thomas
O.K, using v4.4 explains a lot. However, we only accept patches
against:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
I still suggest you only do the PHY driver parts, and don't touch the
MAC driver.
Andrew
prev parent reply other threads:[~2017-03-28 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 10:12 [PATCH 1/1] ethtool : added get_phy_stats,get_strings,get_sset_count Thomas Scariah
2017-03-27 16:44 ` Florian Fainelli
2017-03-27 17:26 ` Andrew Lunn
2017-03-27 17:38 ` Andrew Lunn
2017-03-28 6:45 ` [EXTERNAL] Re: [PATCH 1/1] ethtool : added get_phy_stats, get_strings,get_sset_count Scariah, Thomas
[not found] ` <CA+1hMaGV-trVT+ZisgTtyRAVz=ZqopmwmpWyqHvWQMrkmv-96A@mail.gmail.com>
2017-03-28 12:10 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328121029.GB3152@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=drivshin@allworx.com \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=thomas.scariah@harman.com \
--cc=thomasscariah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.