From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v5 7/7] net/ark: Arkville PMD component integration Date: Tue, 28 Mar 2017 17:00:07 +0200 Message-ID: <20170328150007.GJ3790@6wind.com> References: <41265c4fa76265df0144d5d480e4553888df2ee8.1490309515.git.ed.czeck@atomicrules.com> <3d68039422963c92ef6f05ad4bd9b0b3497eb7bd.1490309515.git.ed.czeck@atomicrules.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ed Czeck , dev@dpdk.org, john.miller@atomicrules.com, shepard.siegel@atomicrules.com, stephen@networkplumber.org To: Ferruh Yigit Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 8E215CF8A for ; Tue, 28 Mar 2017 17:00:17 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id o81so889410wmb.1 for ; Tue, 28 Mar 2017 08:00:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 28, 2017 at 03:38:13PM +0100, Ferruh Yigit wrote: > On 3/23/2017 11:01 PM, Ed Czeck wrote: > > * Flesh out device configuration > > * Add links dev_ops > > * allow dynamic extension loading > > > > Signed-off-by: Shepard Siegel > > Signed-off-by: John Miller > > Signed-off-by: Ed Czeck [...] > > + /* > > + * We will create additional devices based on the number of requested > > + * ports > > + */ > > + int pc = 1; > > + int p; > > I am aware some people prefer the declaring variables close to context, > which is good idea, but if I remember correct, there was a patchset, > from Adrien, to make DPDK C99 compatible, will this break it? [...] Only replying to this part, declaring variables anywhere is fine since C99, so no problem. This is not the preferred style in DPDK as abusing this sometimes makes the code less readable (can lead to super large functions without consistent code blocks). -- Adrien Mazarguil 6WIND