From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Take rpm wakelock around debugfs/i915_gpu_info
Date: Tue, 28 Mar 2017 16:01:37 +0100 [thread overview]
Message-ID: <20170328150137.GK2909@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <87d1d1wn6n.fsf@gaia.fi.intel.com>
On Tue, Mar 28, 2017 at 04:22:40PM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Capturing GPU state requires the device to be awake in order to read
> > registers. Normally, this is taken along the error handler, but for the
> > direct debugfs access, we cannot make assumptions about the current
> > device state and so either need to wake it up, or abort.
> >
> > Fixes: 5a4c6f1b1b2d ("drm/i915: The return of i915_gpu_info to debugfs")
> > Testcase: igt/pm_rpm/debugfs-read
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>
> doh
More yawn than doh. Who would want to look at the gpu state when it's
not doing anything and then complain it was asleep? :)
Pushed,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-28 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 13:14 [PATCH] drm/i915: Take rpm wakelock around debugfs/i915_gpu_info Chris Wilson
2017-03-28 13:22 ` Mika Kuoppala
2017-03-28 15:01 ` Chris Wilson [this message]
2017-03-28 14:09 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328150137.GK2909@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.