From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdC1PnL (ORCPT ); Tue, 28 Mar 2017 11:43:11 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:44189 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbdC1PnI (ORCPT ); Tue, 28 Mar 2017 11:43:08 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Tue, 28 Mar 2017 16:42:38 +0100 From: Charles Keepax To: Mark Brown CC: Daniel Baluta , Daniel Baluta , Nicolin Chen , , Timur Tabi , , Linux Kernel Mailing List , Liam Girdwood , Takashi Iwai , , Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Message-ID: <20170328154238.GS6986@localhost.localdomain> References: <1490691532-2086-1-git-send-email-daniel.baluta@nxp.com> <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> <20170328092103.GQ6986@localhost.localdomain> <20170328115306.GR6986@localhost.localdomain> <20170328152457.2j5zaxdbdavpuspa@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170328152457.2j5zaxdbdavpuspa@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280132 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2017 at 04:24:57PM +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > > > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL); > > > >> + codec_clk = clk_get(&codec_dev->dev, NULL); > > > > is different from &codec_dev->dev. > > > I get that they are different, I just don't get why changing > > from a devm_clk_get to a clk_get is a better fix than changing > > &codec->dev to &pdev->dev. > > This should be clear from the semantics of clk_get(): you're looking up > the clock in the context of the supplied device and the clock is > attached to the CODEC so you need to look up in the CODEC context. What > would be even better would be to move the allocation of the clock into > the CODEC driver... Ah yes thats what I was missing. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Date: Tue, 28 Mar 2017 16:42:38 +0100 Message-ID: <20170328154238.GS6986@localhost.localdomain> References: <1490691532-2086-1-git-send-email-daniel.baluta@nxp.com> <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> <20170328092103.GQ6986@localhost.localdomain> <20170328115306.GR6986@localhost.localdomain> <20170328152457.2j5zaxdbdavpuspa@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by alsa0.perex.cz (Postfix) with ESMTP id 4429726583C for ; Tue, 28 Mar 2017 17:41:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170328152457.2j5zaxdbdavpuspa@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Daniel Baluta , Liam Girdwood , Xiubo.Lee@gmail.com, Linux Kernel Mailing List , Takashi Iwai , alsa-devel@alsa-project.org, Timur Tabi , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, fabio.estevam@nxp.com, Daniel Baluta List-Id: alsa-devel@alsa-project.org On Tue, Mar 28, 2017 at 04:24:57PM +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > > > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL); > > > >> + codec_clk = clk_get(&codec_dev->dev, NULL); > > > > is different from &codec_dev->dev. > > > I get that they are different, I just don't get why changing > > from a devm_clk_get to a clk_get is a better fix than changing > > &codec->dev to &pdev->dev. > > This should be clear from the semantics of clk_get(): you're looking up > the clock in the context of the supplied device and the clock is > attached to the CODEC so you need to look up in the CODEC context. What > would be even better would be to move the allocation of the clock into > the CODEC driver... Ah yes thats what I was missing. Thanks, Charles