All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ladi Prosek <lprosek@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: arnd@arndb.de, mst@redhat.com
Subject: [PATCH v3 0/3] virtio_balloon: don't push uninitialized buffers to stats virtqueue
Date: Tue, 28 Mar 2017 18:46:56 +0200	[thread overview]
Message-ID: <20170328164659.4311-1-lprosek@redhat.com> (raw)

This series fixes issues with variable initialization in the virtio
balloon driver which manifest as the driver sending invalid memory
stats to the host.

v1->v2:

* Call update_balloon_stats instead of filling the buffer with
  invalid tags.
* Add BUG_ON to update_balloon_stats to formalize the invariant that
  all slots in the buffer must be initialized.

v2->v3:

* Remove BUG_ON and return the actual number of counters from
  update_balloon_stats instead.
* Added Arnd's patch to omit VM stats if CONFIG_VM_EVENT_COUNTERS
  is not defined.


Arnd Bergmann (1):
      virtio_balloon: prevent uninitialized variable use

Ladi Prosek (2):
      virtio_balloon: don't push uninitialized buffers to stats virtqueue
      virtio-balloon: use actual number of stats for stats queue buffers

 drivers/virtio/virtio_balloon.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

Thanks!
Ladi

             reply	other threads:[~2017-03-28 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 16:46 Ladi Prosek [this message]
2017-03-28 16:46 ` [PATCH v3 1/3] virtio_balloon: don't push uninitialized buffers to stats virtqueue Ladi Prosek
2017-03-28 16:46 ` [PATCH v3 2/3] virtio-balloon: use actual number of stats for stats queue buffers Ladi Prosek
2017-03-28 20:33   ` Arnd Bergmann
2017-03-28 16:46 ` [PATCH v3 3/3] virtio_balloon: prevent uninitialized variable use Ladi Prosek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328164659.4311-1-lprosek@redhat.com \
    --to=lprosek@redhat.com \
    --cc=arnd@arndb.de \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.