* [PATCH] iio: adc: max1363: constify attribute_group structures
@ 2017-03-28 20:15 simran singhal
2017-03-29 21:11 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: simran singhal @ 2017-03-28 20:15 UTC (permalink / raw)
To: jic23
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel, outreachy-kernel
Check for attribute_group structures that are only stored in the
event_attrs filed of iio_info structure. As the event_attrs field of
iio_info structures is constant, so these attribute_group structures can
also be declared constant. Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};
@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;
File size before:
text data bss dec hex filename
36951 448 0 37399 9217 drivers/iio/adc/max1363.o
File size after:
text data bss dec hex filename
37015 384 0 37399 9217 drivers/iio/adc/max1363.o
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/iio/adc/max1363.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index c6c12fe..80eada4 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
NULL,
};
-static struct attribute_group max1363_event_attribute_group = {
+static const struct attribute_group max1363_event_attribute_group = {
.attrs = max1363_event_attributes,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: max1363: constify attribute_group structures
2017-03-28 20:15 [PATCH] iio: adc: max1363: constify attribute_group structures simran singhal
@ 2017-03-29 21:11 ` Jonathan Cameron
2017-03-29 21:28 ` SIMRAN SINGHAL
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2017-03-29 21:11 UTC (permalink / raw)
To: simran singhal
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel, outreachy-kernel
On 28/03/17 21:15, simran singhal wrote:
> Check for attribute_group structures that are only stored in the
> event_attrs filed of iio_info structure. As the event_attrs field of
> iio_info structures is constant, so these attribute_group structures can
> also be declared constant. Done using coccinelle:
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct attribute_group i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct iio_info x;
> @@
> x.event_attrs=&i@p;
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct attribute_group i={...};
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct attribute_group i;
>
> File size before:
> text data bss dec hex filename
> 36951 448 0 37399 9217 drivers/iio/adc/max1363.o
>
> File size after:
> text data bss dec hex filename
> 37015 384 0 37399 9217 drivers/iio/adc/max1363.o
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/max1363.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index c6c12fe..80eada4 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
> NULL,
> };
>
> -static struct attribute_group max1363_event_attribute_group = {
> +static const struct attribute_group max1363_event_attribute_group = {
> .attrs = max1363_event_attributes,
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: max1363: constify attribute_group structures
2017-03-29 21:11 ` Jonathan Cameron
@ 2017-03-29 21:28 ` SIMRAN SINGHAL
2017-03-29 21:31 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: SIMRAN SINGHAL @ 2017-03-29 21:28 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, Linux Kernel Mailing List, outreachy-kernel
On Thu, Mar 30, 2017 at 2:41 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 28/03/17 21:15, simran singhal wrote:
>> Check for attribute_group structures that are only stored in the
>> event_attrs filed of iio_info structure. As the event_attrs field of
>> iio_info structures is constant, so these attribute_group structures can
>> also be declared constant. Done using coccinelle:
>>
>> @r1 disable optional_qualifier @
>> identifier i;
>> position p;
>> @@
>> static struct attribute_group i@p = {...};
>>
>> @ok1@
>> identifier r1.i;
>> position p;
>> struct iio_info x;
>> @@
>> x.event_attrs=&i@p;
>>
>> @bad@
>> position p!={r1.p,ok1.p};
>> identifier r1.i;
>> @@
>> i@p
>>
>> @depends on !bad disable optional_qualifier@
>> identifier r1.i;
>> @@
>> static
>> +const
>> struct attribute_group i={...};
>>
>> @depends on !bad disable optional_qualifier@
>> identifier r1.i;
>> @@
>> +const
>> struct attribute_group i;
>>
>> File size before:
>> text data bss dec hex filename
>> 36951 448 0 37399 9217 drivers/iio/adc/max1363.o
>>
>> File size after:
>> text data bss dec hex filename
>> 37015 384 0 37399 9217 drivers/iio/adc/max1363.o
>>
>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
>
But my tree is up-to-date and I also test it before sending.
> Thanks,
>
> Jonathan
>> ---
>> drivers/iio/adc/max1363.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
>> index c6c12fe..80eada4 100644
>> --- a/drivers/iio/adc/max1363.c
>> +++ b/drivers/iio/adc/max1363.c
>> @@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
>> NULL,
>> };
>>
>> -static struct attribute_group max1363_event_attribute_group = {
>> +static const struct attribute_group max1363_event_attribute_group = {
>> .attrs = max1363_event_attributes,
>> };
>>
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] iio: adc: max1363: constify attribute_group structures
2017-03-29 21:28 ` SIMRAN SINGHAL
@ 2017-03-29 21:31 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-03-29 21:31 UTC (permalink / raw)
To: SIMRAN SINGHAL
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio, Linux Kernel Mailing List,
outreachy-kernel
On Thu, 30 Mar 2017, SIMRAN SINGHAL wrote:
> On Thu, Mar 30, 2017 at 2:41 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> > On 28/03/17 21:15, simran singhal wrote:
> >> Check for attribute_group structures that are only stored in the
> >> event_attrs filed of iio_info structure. As the event_attrs field of
> >> iio_info structures is constant, so these attribute_group structures can
> >> also be declared constant. Done using coccinelle:
> >>
> >> @r1 disable optional_qualifier @
> >> identifier i;
> >> position p;
> >> @@
> >> static struct attribute_group i@p = {...};
> >>
> >> @ok1@
> >> identifier r1.i;
> >> position p;
> >> struct iio_info x;
> >> @@
> >> x.event_attrs=&i@p;
> >>
> >> @bad@
> >> position p!={r1.p,ok1.p};
> >> identifier r1.i;
> >> @@
> >> i@p
> >>
> >> @depends on !bad disable optional_qualifier@
> >> identifier r1.i;
> >> @@
> >> static
> >> +const
> >> struct attribute_group i={...};
> >>
> >> @depends on !bad disable optional_qualifier@
> >> identifier r1.i;
> >> @@
> >> +const
> >> struct attribute_group i;
> >>
> >> File size before:
> >> text data bss dec hex filename
> >> 36951 448 0 37399 9217 drivers/iio/adc/max1363.o
> >>
> >> File size after:
> >> text data bss dec hex filename
> >> 37015 384 0 37399 9217 drivers/iio/adc/max1363.o
> >>
> >> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to play with it.
> >
>
> But my tree is up-to-date and I also test it before sending.
One never knows...
julia
>
> > Thanks,
> >
> > Jonathan
> >> ---
> >> drivers/iio/adc/max1363.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> >> index c6c12fe..80eada4 100644
> >> --- a/drivers/iio/adc/max1363.c
> >> +++ b/drivers/iio/adc/max1363.c
> >> @@ -1007,7 +1007,7 @@ static struct attribute *max1363_event_attributes[] = {
> >> NULL,
> >> };
> >>
> >> -static struct attribute_group max1363_event_attribute_group = {
> >> +static const struct attribute_group max1363_event_attribute_group = {
> >> .attrs = max1363_event_attributes,
> >> };
> >>
> >>
> >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyOPVDA%2B4n56d3c%2BjZRsiaQ52vYEjA%2BOr1j8Z2LNgi58OQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-29 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 20:15 [PATCH] iio: adc: max1363: constify attribute_group structures simran singhal
2017-03-29 21:11 ` Jonathan Cameron
2017-03-29 21:28 ` SIMRAN SINGHAL
2017-03-29 21:31 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.